[PATCH v6 15/21] arch_topology: Avoid parsing through all the CPUs once a outlier CPU is found
Sudeep Holla
sudeep.holla at arm.com
Mon Jul 4 03:15:59 PDT 2022
There is no point in looping through all the CPU's physical package
identifier to check if it is valid or not once a CPU which is outside
the topology(i.e. outlier CPU) is found.
Let us just break out of the loop early in such case.
Tested-by: Ionela Voinescu <ionela.voinescu at arm.com>
Reviewed-by: Gavin Shan <gshan at redhat.com>
Signed-off-by: Sudeep Holla <sudeep.holla at arm.com>
---
drivers/base/arch_topology.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index c0b0ee64a79d..8f6a964d2512 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -642,8 +642,10 @@ static int __init parse_dt_topology(void)
* only mark cores described in the DT as possible.
*/
for_each_possible_cpu(cpu)
- if (cpu_topology[cpu].package_id < 0)
+ if (cpu_topology[cpu].package_id < 0) {
ret = -EINVAL;
+ break;
+ }
out_map:
of_node_put(map);
--
2.37.0
More information about the linux-arm-kernel
mailing list