[PATCH] arm64: trap implementation defined functionality in userspace

Kristina Martsenko kristina.martsenko at arm.com
Fri Jul 1 13:11:26 PDT 2022


On 29/06/2022 12:27, Mark Brown wrote:
> On Wed, Jun 22, 2022 at 12:54:24PM +0100, Kristina Martsenko wrote:
> 
>> +++ b/arch/arm64/include/asm/sysreg.h
>> @@ -902,6 +902,7 @@
>>  
>>  /* id_aa64mmfr1 */
>>  #define ID_AA64MMFR1_ECBHB_SHIFT	60
>> +#define ID_AA64MMFR1_TIDCP1_SHIFT	52
>>  #define ID_AA64MMFR1_HCX_SHIFT		40
>>  #define ID_AA64MMFR1_AFP_SHIFT		44
>>  #define ID_AA64MMFR1_ETS_SHIFT		36
>> @@ -918,6 +919,9 @@
>>  #define ID_AA64MMFR1_VMIDBITS_8		0
>>  #define ID_AA64MMFR1_VMIDBITS_16	2
>>  
>> +#define ID_AA64MMFR1_TIDCP1_NI		0
>> +#define ID_AA64MMFR1_TIDCP1_IMP		1
> 
> Infradead being infradead meant I unfortunately didn't see this until
> after it was applied so it's a bit late but you're adding defines to
> sysreg.h rather than converting to be generated with gen-sysreg.awk -
> please consider converting this register to automatic generation (which
> could also be done incrementally).

Sure, I'll look at sending a separate patch to convert this register.

Thanks,
Kristina



More information about the linux-arm-kernel mailing list