[PATCH v3] kselftest: kvm/arm64: Skip tests if we can't create a vgic-v3

Shuah Khan skhan at linuxfoundation.org
Wed Jan 26 12:03:44 PST 2022


On 1/26/22 12:52 PM, Mark Brown wrote:
> On Wed, Jan 26, 2022 at 12:22:41PM -0700, Shuah Khan wrote:
>> On 1/26/22 7:52 AM, Mark Brown wrote:
> 
>>> +	ret = vgic_v3_setup(vm, nr_vcpus, 64, GICD_BASE_GPA, GICR_BASE_GPA);
>>> +	if (ret < 0) {
>>> +		print_skip("Failed to create vgic-v3");
> 
>> Printing the negative error code returned by vgic_v3_setup will be useful.
> 
> If the function fails for any reason other than the system not
> supporting vgic-v3 it will abort rather than return.
> 

Hmm. vgic_v3_setup() return gic_fd looks like and the interface says
Return: GIC file-descriptor or negative error code upon failure

I don't follow the abort part.

thanks,
-- Shuah



More information about the linux-arm-kernel mailing list