[PATCH] coresight: tmc: change device registration from misc to cdev

Leo Yan leo.yan at linaro.org
Mon Jan 24 22:54:32 PST 2022


Hi Jay,

On Tue, Jan 25, 2022 at 10:33:45AM +0800, Jiankang Chen wrote:
> Hi Mathieu
> 
> 在 2022/1/25 04:08, Mathieu Poirier 写道:
> > On Mon, 24 Jan 2022 at 04:00, Jay Chen <jkchen at linux.alibaba.com> wrote:
> > > Currently, there are 130 etr and etf on our machine,
> > > but the current coresight tmc driver uses misc_register
> > > to register the device, which leads to the error that
> > > the device number is not enough.
> > > 
> > > coresight-tmc: probe of xxxxx failed with error -16
> > > 
> > > This patch changes the device registration method
> > > to cdev's dynamic registration method to solve the
> > > problem of insufficient device numbers.
> > This patch is still not labelled properly and as such being dropped.
> 
> Hello, about the label of this patch, what kind of patch should I add?

You could use "git format" command with option "-v" to add the version
number, e.g. if you are committing patch version 4, so you can generate
patch like:

  $ git format-patch HEAD~1 -v4

Or if you want to generate patch for a specific commit:

  $ git format-patch -1 patch_commit -v4

Every time when you generate a new version's patch, you could
increment the version number with option "-v4", "-v5", and so on.

P.s. I strongly suggest Marc Zyngier's great talk for how to upstream
kernel patch in a good way:
https://events19.linuxfoundation.org/wp-content/uploads/2017/12/Getting-Your-Patches-in-Mainline-Linux-What-Not-To-Do-and-a-Few-Things-You-Could-Try-Instead-Marc-Zyngier-ARM.pdf

Thanks,
Leo



More information about the linux-arm-kernel mailing list