[PATCH v2] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI

Eric Biggers ebiggers at kernel.org
Mon Jan 24 22:40:42 PST 2022


On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote:
> blake2s_compress_generic is weakly aliased by blake2s_generic. The

Don't you mean "weakly aliased by blake2s_compress"?

> Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in")
> Reported-by: Miles Chen <miles.chen at mediatek.com>
> Tested-by: Miles Chen <miles.chen at mediatek.com>
> Tested-by: Nathan Chancellor <nathan at kernel.org>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1567
> Cc: Nick Desaulniers <ndesaulniers at google.com>
> Cc: Sami Tolvanen <samitolvanen at google.com>
> Cc: Ard Biesheuvel <ardb at kernel.org>
> Signed-off-by: Jason A. Donenfeld <Jason at zx2c4.com>
> ---

Otherwise this looks fine, though it's unfortunate this is needed.  You can add:

	Reviewed-by: Eric Biggers <ebiggers at google.com>

> Changes v1->v2:
> - Wrapped columns at 80 for Eric.

It is the recommended coding style, so not just for me :-)

- Eric



More information about the linux-arm-kernel mailing list