[PATCH v1 1/2] kselftest/arm64: Skip VL_INHERIT tests for unsupported vector types

Mark Brown broonie at kernel.org
Mon Jan 24 13:33:29 PST 2022


On Mon, Jan 24, 2022 at 02:27:07PM -0700, Shuah Khan wrote:
> On 1/24/22 10:55 AM, Mark Brown wrote:

> > -		ptrace_set_get_inherit(child, &vec_types[i]);
> > +		if (getauxval(vec_types[i].hwcap_type) & vec_types[i].hwcap) {
> > +			ptrace_set_get_inherit(child, &vec_types[i]);
> > +		} else {
> > +			ksft_test_result_skip("%s SVE_PT_VL_INHERIT set\n",
> > +					      vec_types[i].name);
> > +			ksft_test_result_skip("%s SVE_PT_VL_INHERIT cleared\n",
> > +					      vec_types[i].name);

> These messages are a bit confusing. Are we skipping two tests?

ptrace_set_get_inherit() logs two test results (one for set, one for get).

> These messages can be combined into one like this one on lin 572:

> ksft_test_result_skip("%s get/set VL %d\n", vec_types[i].name, vl);

If we do that then the number of planned tests won't line up with the
number of expected tests.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20220124/188256e8/attachment.sig>


More information about the linux-arm-kernel mailing list