[PATCH v1 14/14] dt-bindings: media: mediatek: mdp3: add yaml for new modules added in mt8195

[Rob Herring]

On Sun, Jan 16, 2022 at 11:53 PM roy-cw.yeh <roy-cw.yeh at mediatek.com> wrote:
>
> From: "Roy-CW.Yeh" <roy-cw.yeh at mediatek.com>
>
> Add yaml for new modules added in mt8195
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh at mediatek.com>
> ---
> This patch is base on [1]
> [1] dt-bindings: arm: mediatek: move out common module from display folder
> - https://patchwork.kernel.org/project/linux-mediatek/patch/20220107101425.6917-8-jason-jh.lin@mediatek.com/

Looks to me like this is based on:

https://lore.kernel.org/r/20220105093758.6850-1-moudy.ho@mediatek.com

Can we have some coordination between all the MDP3 series. I have no
idea how all these sub-blocks fit together to provide any meaningful
review.

> ---
>  .../bindings/arm/mediatek/mediatek,mmsys.yaml |  2 +
>  .../bindings/media/mediatek,mdp3-aal.yaml     | 56 +++++++++++++++++
>  .../bindings/media/mediatek,mdp3-color.yaml   | 56 +++++++++++++++++
>  .../bindings/media/mediatek,mdp3-fg.yaml      | 55 +++++++++++++++++
>  .../bindings/media/mediatek,mdp3-hdr.yaml     | 55 +++++++++++++++++
>  .../bindings/media/mediatek,mdp3-merge.yaml   | 54 ++++++++++++++++
>  .../bindings/media/mediatek,mdp3-ovl.yaml     | 53 ++++++++++++++++
>  .../bindings/media/mediatek,mdp3-pad.yaml     | 56 +++++++++++++++++
>  .../bindings/media/mediatek,mdp3-rdma.yaml    | 28 +++++++++
>  .../bindings/media/mediatek,mdp3-rsz.yaml     |  2 +
>  .../bindings/media/mediatek,mdp3-split.yaml   | 58 ++++++++++++++++++
>  .../bindings/media/mediatek,mdp3-stitch.yaml  | 53 ++++++++++++++++
>  .../bindings/media/mediatek,mdp3-tcc.yaml     | 54 ++++++++++++++++
>  .../bindings/media/mediatek,mdp3-tdshp.yaml   | 61 +++++++++++++++++++
>  .../bindings/media/mediatek,mdp3-wrot.yaml    |  3 +
>  .../bindings/soc/mediatek/mediatek,mutex.yaml |  6 ++
>  16 files changed, 652 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-aal.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-color.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-merge.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-ovl.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-split.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-stitch.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
> index 763c62323a74..9e59c8b738bb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
> @@ -31,6 +31,8 @@ properties:
>                - mediatek,mt8183-mmsys
>                - mediatek,mt8192-mmsys
>                - mediatek,mt8365-mmsys
> +              - mediatek,mt8195-vppsys0
> +              - mediatek,mt8195-vppsys1

What's the difference between 0 and 1? Defining instance indices is
not how things are described in DT. If this is just the same block
with different connections, then you should be describing the
connections (with the graph binding). If there's some other
difference, then maybe those should be properties. I'm pretty sure
I've said this before.

The same question applies to the rest of the schemas with numbering.

Rob