[PATCH v2 04/16] clk: samsung: fsd: Add initial clock support

[Stephen Boyd]

Quoting Alim Akhtar (2022-01-20 05:53:31)
> Hi Stephen
> 
> >-----Original Message-----
> >From: Stephen Boyd [mailto:sboyd at kernel.org]
> >Sent: Thursday, January 20, 2022 1:45 AM
> >To: Alim Akhtar <alim.akhtar at samsung.com>; linux-arm-
> >kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> >Cc: soc at kernel.org; linux-clk at vger.kernel.org; devicetree at vger.kernel.org;
> >olof at lixom.net; arnd at arndb.de; linus.walleij at linaro.org;
> >catalin.marinas at arm.com; robh+dt at kernel.org;
> >krzysztof.kozlowski at canonical.com; s.nawrocki at samsung.com; linux-
> >samsung-soc at vger.kernel.org; pankaj.dubey at samsung.com; Alim Akhtar
> ><alim.akhtar at samsung.com>; linux-fsd at tesla.com; Jayati Sahu
> ><jayati.sahu at samsung.com>; Ajay Kumar <ajaykumar.rs at samsung.com>
> >Subject: Re: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support
> >
> >Quoting Alim Akhtar (2022-01-18 06:48:39)
> >> diff --git a/drivers/clk/samsung/clk-fsd.c
> >> b/drivers/clk/samsung/clk-fsd.c new file mode 100644 index
> >> 000000000000..2669396d81b9
> >> --- /dev/null
> >> +++ b/drivers/clk/samsung/clk-fsd.c
> >> @@ -0,0 +1,308 @@
> >> +// SPDX-License-Identifier: GPL-2.0-only
> >> +/*
> >> + * Copyright (c) 2017-2022 Samsung Electronics Co., Ltd.
> >> + *             https://www.samsung.com
> >> + * Copyright (c) 2017-2022 Tesla, Inc.
> >> + *             https://www.tesla.com
> >> + *
> >> + * Common Clock Framework support for FSD SoC.
> >> + */
> >> +
> >> +#include <linux/clk-provider.h>
> >> +#include <linux/of.h>
> >
> >include init.h for __initconst and kernel.h for ARRAY_SIZE
> >
> I did not face any compilation error.
> Do I need to explicitly add these header files in driver? I see clk.h implicitly includes kernel.h
> Same is the case of other driver in this directory.

Yes they should be included. Depending on implicit includes leads to
pain later when that include is moved out of the header and compilation
breaks here. Include what you use, thanks!