[PATCH 14/23] arm64: dts: fsd: Add initial device tree support

Alim Akhtar alim.akhtar at samsung.com
Sat Jan 15 07:31:24 PST 2022



>-----Original Message-----
>From: Rob Herring [mailto:robh+dt at kernel.org]
>Sent: Friday, January 14, 2022 8:16 AM
>To: Alim Akhtar <alim.akhtar at samsung.com>
>Cc: linux-arm-kernel <linux-arm-kernel at lists.infradead.org>; linux-
>kernel at vger.kernel.org; SoC Team <soc at kernel.org>; linux-clk <linux-
>clk at vger.kernel.org>; devicetree at vger.kernel.org; Olof Johansson
><olof at lixom.net>; Linus Walleij <linus.walleij at linaro.org>; Catalin Marinas
><catalin.marinas at arm.com>; Krzysztof Kozlowski
><krzysztof.kozlowski at canonical.com>; Sylwester Nawrocki
><s.nawrocki at samsung.com>; linux-samsung-soc <linux-samsung-
>soc at vger.kernel.org>; Pankaj Dubey <pankaj.dubey at samsung.com>; linux-
>fsd at tesla.com; Arjun K V <arjun.kv at samsung.com>; Aswani Reddy
><aswani.reddy at samsung.com>; Ajay Kumar <ajaykumar.rs at samsung.com>;
>Sriranjani P <sriranjani.p at samsung.com>; Chandrasekar R
><rcsekar at samsung.com>; Shashank Prashar <s.prashar at samsung.com>
>Subject: Re: [PATCH 14/23] arm64: dts: fsd: Add initial device tree support
>
>On Thu, Jan 13, 2022 at 6:24 AM Alim Akhtar <alim.akhtar at samsung.com>
>wrote:
>>
>> Add initial device tree support for "Full Self-Driving" (FSD) SoC This
>> SoC contain three clusters of four cortex-a72 CPUs and various
>> peripheral IPs.
>
>Please make sure you run this thru 'make dtbs_check'. Fix schema warnings as
>much as possible and all dtc warnings. If shared with Samsung, there's
>probably a bit still missing. I see several warnings so I won't bother manually
>reporting them here.
>
Thanks Rob for review, let me fix them in patch set v2.

>> Cc: linux-fsd at tesla.com
>> Signed-off-by: Arjun K V <arjun.kv at samsung.com>
>> Signed-off-by: Aswani Reddy <aswani.reddy at samsung.com>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs at samsung.com>
>> Signed-off-by: Sriranjani P <sriranjani.p at samsung.com>
>> Signed-off-by: Chandrasekar R <rcsekar at samsung.com>
>> Signed-off-by: Shashank Prashar <s.prashar at samsung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar at samsung.com>
>> ---
>>  MAINTAINERS                        |   8 +
>>  arch/arm64/Kconfig.platforms       |   6 +
>>  arch/arm64/boot/dts/Makefile       |   1 +
>>  arch/arm64/boot/dts/tesla/Makefile |   3 +
>>  arch/arm64/boot/dts/tesla/fsd.dts  | 140 ++++++
>> arch/arm64/boot/dts/tesla/fsd.dtsi | 715
>+++++++++++++++++++++++++++++
>>  6 files changed, 873 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/tesla/Makefile
>>  create mode 100644 arch/arm64/boot/dts/tesla/fsd.dts  create mode
>> 100644 arch/arm64/boot/dts/tesla/fsd.dtsi
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS index
>> fb18ce7168aa..02d56909c5e2 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2726,6 +2726,14 @@ S:       Maintained
>>  F:     Documentation/devicetree/bindings/media/tegra-cec.txt
>>  F:     drivers/media/cec/platform/tegra/
>>
>> +ARM/TESLA FSD SoC SUPPORT
>> +M:     Alim Akhtar <alim.akhtar at samsung.com>
>> +M:     linux-fsd at tesla.com
>> +L:     linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
>> +L:     linux-samsung-soc at vger.kernel.org
>> +S:     Maintained
>> +F:     arch/arm64/boot/dts/tesla*
>> +
>>  ARM/TETON BGA MACHINE SUPPORT
>>  M:     "Mark F. Brown" <mark.brown314 at gmail.com>
>>  L:     linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
>> diff --git a/arch/arm64/Kconfig.platforms
>> b/arch/arm64/Kconfig.platforms index 54e3910e8b9b..bb8a047c2359 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -267,6 +267,12 @@ config ARCH_TEGRA
>>         help
>>           This enables support for the NVIDIA Tegra SoC family.
>>
>> +config ARCH_TESLA_FSD
>> +       bool "ARMv8 based Tesla platform"
>> +       select ARCH_EXYNOS
>> +       help
>> +         Support for ARMv8 based Tesla platforms.
>> +
>>  config ARCH_SPRD
>>         bool "Spreadtrum SoC platform"
>>         help
>> diff --git a/arch/arm64/boot/dts/Makefile
>> b/arch/arm64/boot/dts/Makefile index 639e01a4d855..1ba04e31a438
>100644
>> --- a/arch/arm64/boot/dts/Makefile
>> +++ b/arch/arm64/boot/dts/Makefile
>> @@ -27,6 +27,7 @@ subdir-y += rockchip  subdir-y += socionext
>> subdir-y += sprd  subdir-y += synaptics
>> +subdir-y += tesla
>>  subdir-y += ti
>>  subdir-y += toshiba
>>  subdir-y += xilinx
>> diff --git a/arch/arm64/boot/dts/tesla/Makefile
>> b/arch/arm64/boot/dts/tesla/Makefile
>> new file mode 100644
>> index 000000000000..a9818cda6b08
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/tesla/Makefile
>> @@ -0,0 +1,3 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +dtb-$(CONFIG_ARCH_TESLA_FSD) += \
>> +       fsd.dtb
>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dts
>> b/arch/arm64/boot/dts/tesla/fsd.dts
>> new file mode 100644
>> index 000000000000..e9bbd3284de9
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/tesla/fsd.dts
>> @@ -0,0 +1,140 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
>Dual license dts files please.
>
>> +/*
>> + * Tesla FSD board device tree source
>> + *
>> + * Copyright (c) 2017-2021 Samsung Electronics Co., Ltd.
>> + *             https://www.samsung.com
>> + * Copyright (c) 2017-2021 Tesla, Inc.
>> + *             https://www.tesla.com
>> + */
>> +
>> +/dts-v1/;
>> +#include "fsd.dtsi"
>> +
>> +/ {
>> +       model = "Tesla Full Self-Driving (FSD) SoC";
>> +       compatible = "tesla,fsd";
>> +
>> +       aliases {
>> +               serial0 = &serial_0;
>> +               serial1 = &serial_1;
>> +       };
>> +
>> +       chosen {
>> +               stdout-path = &serial_0;
>
>> +               linux,initrd-start = <0xE0000000>;
>> +               linux,initrd-end = <0xE4F00000>;
>
>Bootloaders set these.
>
>> +               bootargs = "console=ttySAC0,115200n8
>
>Not needed with stdout-path.
>
>> +                       earlycon=exynos4210,0x14180000 root=/dev/ram0
>
>earlycon is a debug option.
>
>> +                       init=/linuxrc";
>
>init and rootfs are user settings.
>
>> +       };
>> +
>> +       memory at 80000000 {
>> +               device_type = "memory";
>> +               reg = <0x0 0x80000000 0x2 0x00000000>;
>> +       };
>> +};
>> +
>> +&fin_pll {
>> +       clock-frequency = <24000000>;
>> +};
>> +
>> +&serial_0 {
>> +       status = "okay";
>> +};
>> +
>> +&serial_1 {
>> +       status = "okay";
>> +};
>> +
>> +&clock_cmu {
>> +       status = "okay";
>> +};
>> +
>> +&clock_imem {
>> +       status = "okay";
>> +};
>> +
>> +&clock_peric {
>> +       status = "okay";
>> +};
>> +
>> +&smmu_isp {
>> +       status = "okay";
>> +};
>> +
>> +&clock_fsys0 {
>> +       status = "okay";
>> +};
>> +
>> +&clock_fsys1 {
>> +       status = "okay";
>> +};
>> +
>> +&smmu_peric {
>> +       status = "okay";
>> +};
>> +
>> +&smmu_imem {
>> +       status = "okay";
>> +};
>> +
>> +&smmu_fsys0 {
>> +       status = "okay";
>> +};
>> +
>> +&hsi2c_0 {
>> +       status = "okay";
>> +};
>> +
>> +&hsi2c_1 {
>> +       status = "okay";
>> +};
>> +
>> +&hsi2c_2 {
>> +       status = "okay";
>> +};
>> +
>> +&hsi2c_3 {
>> +       status = "okay";
>> +};
>> +
>> +&hsi2c_4 {
>> +       status = "okay";
>> +};
>> +
>> +&hsi2c_5 {
>> +       status = "okay";
>> +};
>> +
>> +&hsi2c_6 {
>> +       status = "okay";
>> +};
>> +
>> +&hsi2c_7 {
>> +       status = "okay";
>> +};
>> +
>> +&pwm_0 {
>> +       status = "okay";
>> +};
>> +
>> +&pwm_1 {
>> +       status = "okay";
>> +};
>> +
>> +&mdma0 {
>> +       status = "okay";
>> +};
>> +
>> +&mdma1 {
>> +       status = "okay";
>> +};
>> +
>> +&pdma0 {
>> +       status = "okay";
>> +};
>> +
>> +&pdma1 {
>> +       status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
>> b/arch/arm64/boot/dts/tesla/fsd.dtsi
>> new file mode 100644
>> index 000000000000..47cd9f20566e
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
>> @@ -0,0 +1,715 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Tesla Full Self-Driving SoC device tree source
>> + *
>> + * Copyright (c) 2017-2022 Samsung Electronics Co., Ltd.
>> + *             https://www.samsung.com
>> + * Copyright (c) 2017-2022 Tesla, Inc.
>> + *             https://www.tesla.com
>> + */
>> +
>> +#include <dt-bindings/clock/fsd-clk.h> #include
>> +<dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> +/ {
>> +       compatible = "tesla,fsd";
>> +       interrupt-parent = <&gic>;
>> +       #address-cells = <2>;
>> +       #size-cells = <2>;
>> +
>> +       aliases {
>> +               watchdog0 = &watchdog_0;
>> +               watchdog1 = &watchdog_1;
>> +               watchdog2 = &watchdog_2;
>> +               hsi2c0 = &hsi2c_0;
>> +               hsi2c1 = &hsi2c_1;
>> +               hsi2c2 = &hsi2c_2;
>> +               hsi2c3 = &hsi2c_3;
>> +               hsi2c4 = &hsi2c_4;
>> +               hsi2c5 = &hsi2c_5;
>> +               hsi2c6 = &hsi2c_6;
>> +               hsi2c7 = &hsi2c_7;
>
>Drop all these non-standard aliases.
>
>> +       };
>> +
>> +       cpus {
>> +               #address-cells = <2>;
>> +               #size-cells = <0>;
>> +
>> +               cpu-map {
>> +                       cluster0 {
>> +                               core0 {
>> +                                       cpu = <&cpucl0_0>;
>> +                               };
>> +                               core1 {
>> +                                       cpu = <&cpucl0_1>;
>> +                               };
>> +                               core2 {
>> +                                       cpu = <&cpucl0_2>;
>> +                               };
>> +                               core3 {
>> +                                       cpu = <&cpucl0_3>;
>> +                               };
>> +                       };
>> +
>> +                       cluster1 {
>> +                               core0 {
>> +                                       cpu = <&cpucl1_0>;
>> +                               };
>> +                               core1 {
>> +                                       cpu = <&cpucl1_1>;
>> +                               };
>> +                               core2 {
>> +                                       cpu = <&cpucl1_2>;
>> +                               };
>> +                               core3 {
>> +                                       cpu = <&cpucl1_3>;
>> +                               };
>> +                       };
>> +
>> +                       cluster2 {
>> +                               core0 {
>> +                                       cpu = <&cpucl2_0>;
>> +                               };
>> +                               core1 {
>> +                                       cpu = <&cpucl2_1>;
>> +                               };
>> +                               core2 {
>> +                                       cpu = <&cpucl2_2>;
>> +                               };
>> +                               core3 {
>> +                                       cpu = <&cpucl2_3>;
>> +                               };
>> +                       };
>> +               };
>> +
>> +               /* Cluster 0 */
>> +               cpucl0_0: cpu at 0 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x000>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               cpucl0_1: cpu at 1 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x001>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               cpucl0_2: cpu at 2 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x002>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               cpucl0_3: cpu at 3 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x003>;
>> +                               enable-method = "psci";
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               /* Cluster 1 */
>> +               cpucl1_0: cpu at 100 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x100>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               cpucl1_1: cpu at 101 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x101>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               cpucl1_2: cpu at 102 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x102>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               cpucl1_3: cpu at 103 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x103>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               /* Cluster 2 */
>> +               cpucl2_0: cpu at 200 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x200>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               cpucl2_1: cpu at 201 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x201>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               cpucl2_2: cpu at 202 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x202>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               cpucl2_3: cpu at 203 {
>> +                               device_type = "cpu";
>> +                               compatible = "arm,cortex-a72";
>> +                               reg = <0x0 0x203>;
>> +                               enable-method = "psci";
>> +                               clock-frequency = <2400000000>;
>> +                               cpu-idle-states = <&CPU_SLEEP>;
>> +                               next-level-cache = <&L2_0>;
>> +               };
>> +
>> +               idle-states {
>> +                       entry-method = "arm,psci";
>> +
>> +                       CPU_SLEEP: cpu-sleep {
>> +                               idle-state-name = "c2";
>> +                               compatible = "arm,idle-state";
>> +                               local-timer-stop;
>> +                               arm,psci-suspend-param = <0x0010000>;
>> +                               entry-latency-us = <30>;
>> +                               exit-latency-us = <75>;
>> +                               min-residency-us = <300>;
>> +                               status = "okay";
>> +                       };
>> +               };
>> +
>> +               L2_0: l2-cache0 {
>> +                       compatible = "cache";
>> +               };
>> +       };
>> +
>> +       arm-pmu {
>> +               compatible = "arm,armv8-pmuv3";
>> +               interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 372 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 384 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 385 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 386 IRQ_TYPE_LEVEL_HIGH>,
>> +                            <GIC_SPI 387 IRQ_TYPE_LEVEL_HIGH>;
>> +               interrupt-affinity = <&cpucl0_0>, <&cpucl0_1>, <&cpucl0_2>,
>> +                                    <&cpucl0_3>, <&cpucl1_0>, <&cpucl1_1>,
>> +                                    <&cpucl1_2>, <&cpucl1_3>, <&cpucl2_0>,
>> +                                    <&cpucl2_1>, <&cpucl2_2>, <&cpucl2_3>;
>> +       };
>> +
>> +       psci {
>> +               compatible = "arm,psci";
>> +               method = "smc";
>
>> +               cpu_on = <0xC4000003>;
>> +               cpu_suspend = <0xC4000001>;
>> +               cpu_off = <0x84000002>;
>
>These codes are standardized since forever. Fix your firmware.
>
>> +       };
>> +
>> +       timer {
>> +               compatible = "arm,armv8-timer";
>> +               interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
>> +                            <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
>> +                            <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
>> +                            <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
>> +       };
>> +
>> +       fin_pll: clock {
>> +               compatible = "fixed-clock";
>> +               clock-output-names = "fin_pll";
>> +               #clock-cells = <0>;
>> +       };
>> +
>> +       soc: soc {
>
>soc at 0
>
>You should see a warning for this.
>
>> +               compatible = "simple-bus";
>> +               #address-cells = <2>;
>> +               #size-cells = <2>;
>> +               ranges = <0x0 0x0 0x0 0x0 0x0 0x18000000>;
>> +               dma-ranges = <0x0 0x0 0x0 0x0 0x10 0x0>;
>> +
>> +               gic: interrupt-controller at 10400000 {
>> +                       compatible = "arm,gic-v3";
>> +                       #interrupt-cells = <3>;
>> +                       interrupt-controller;
>> +                       reg =   <0x0 0x10400000 0x0 0x10000>, /* GICD */
>> +                               <0x0 0x10600000 0x0 0x200000>; /* GICR_RD+GICR_SGI */
>> +               };
>> +
>> +               smmu_isp: iommu at 12100000 {
>> +                       compatible = "arm,mmu-500";
>> +                       reg = <0x0 0x12100000 0x0 0x10000>;
>> +                       #iommu-cells = <2>;
>> +                       #global-interrupts = <11>;
>> +                       interrupts = <GIC_SPI 321 IRQ_TYPE_LEVEL_HIGH>, /* Global
>secure fault */
>> +                                    <GIC_SPI 322 IRQ_TYPE_LEVEL_HIGH>, /* Global non-
>secure fault */
>> +                                    <GIC_SPI 346 IRQ_TYPE_LEVEL_HIGH>, /* Combined
>secure interrupt */
>> +                                    <GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>, /* Combined
>non-secure interrupt */
>> +                                    /* Performance counter interrupts */
>> +                                    <GIC_SPI 323 IRQ_TYPE_LEVEL_HIGH>, /* for CAM_CSI
>*/
>> +                                    <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>, /* for CAM_DP_0
>*/
>> +                                    <GIC_SPI 325 IRQ_TYPE_LEVEL_HIGH>, /* for CAM_DP_1
>*/
>> +                                    <GIC_SPI 326 IRQ_TYPE_LEVEL_HIGH>, /* for
>CAM_ISP_0 */
>> +                                    <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>, /* for
>CAM_ISP_1 */
>> +                                    <GIC_SPI 328 IRQ_TYPE_LEVEL_HIGH>, /* for
>CAM_MFC_0 */
>> +                                    <GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH>, /* for
>CAM_MFC_1 */
>> +                                    /* Per context non-secure context interrupts, 0-7
>interrupts */
>> +                                    <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_0 */
>> +                                    <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_1 */
>> +                                    <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_2 */
>> +                                    <GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_3 */
>> +                                    <GIC_SPI 334 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_4 */
>> +                                    <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_5 */
>> +                                    <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_6 */
>> +                                    <GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH>; /* for
>CONTEXT_7 */
>> +                       status = "disabled";
>
>IOMMU isn't really board specific, should it really be disabled?
>
>> +               };
>> +
>> +               smmu_imem: iommu at 10200000 {
>> +                       compatible = "arm,mmu-500";
>> +                       reg = <0x0 0x10200000 0x0 0x10000>;
>> +                       #iommu-cells = <2>;
>> +                       #global-interrupts = <7>;
>> +                       interrupts = <GIC_SPI 438 IRQ_TYPE_LEVEL_HIGH>, /* Global
>secure fault */
>> +                                    <GIC_SPI 439 IRQ_TYPE_LEVEL_HIGH>, /* Global non-
>secure fault */
>> +                                    <GIC_SPI 451 IRQ_TYPE_LEVEL_HIGH>, /* Combined
>secure interrupt */
>> +                                    <GIC_SPI 450 IRQ_TYPE_LEVEL_HIGH>, /* Combined
>non-secure interrupt */
>> +                                    /* Performance counter interrupts */
>> +                                    <GIC_SPI 441 IRQ_TYPE_LEVEL_HIGH>, /* for FSYS1_0 */
>> +                                    <GIC_SPI 442 IRQ_TYPE_LEVEL_HIGH>, /* for FSYS1_1 */
>> +                                    <GIC_SPI 443 IRQ_TYPE_LEVEL_HIGH>, /* for IMEM_0
>*/
>> +                                    /* Per context non-secure context interrupts, 0-3
>interrupts */
>> +                                    <GIC_SPI 446 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_0 */
>> +                                    <GIC_SPI 447 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_1 */
>> +                                    <GIC_SPI 448 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_2 */
>> +                                    <GIC_SPI 449 IRQ_TYPE_LEVEL_HIGH>; /* for
>CONTEXT_3 */
>> +                       status = "disabled";
>> +               };
>> +
>> +               smmu_peric: iommu at 14900000 {
>> +                       compatible = "arm,mmu-500";
>> +                       reg = <0x0 0x14900000 0x0 0x10000>;
>> +                       #iommu-cells = <2>;
>> +                       #global-interrupts = <5>;
>> +                       interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>, /* Global
>secure fault */
>> +                                    <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>, /* Global non-
>secure fault */
>> +                                    <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>, /* Combined
>secure interrupt */
>> +                                    <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>, /* Combined
>non-secure interrupt */
>> +                                    /* Performance counter interrupts */
>> +                                    <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>, /* for PERIC */
>> +                                    /* Per context non-secure context interrupts, 0-1
>interrupts */
>> +                                    <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>, /* for
>CONTEXT_0 */
>> +                                    <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>; /* for
>CONTEXT_1 */
>> +                       status = "disabled";
>> +               };
>> +
>> +               smmu_fsys0: iommu at 15450000 {
>> +                       compatible = "arm,mmu-500";
>> +                       reg = <0x0 0x15450000 0x0 0x10000>;
>> +                       #iommu-cells = <2>;
>> +                       #global-interrupts = <5>;
>> +                       interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>, /* Global
>secure fault */
>> +                                    <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>, /* Global non-
>secure fault */
>> +                                    <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>, /* Combined
>secure interrupt */
>> +                                    <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>, /* Combined non-
>secure interrupt */
>> +                                    /* Performance counter interrupts */
>> +                                    <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>, /* for FSYS0   */
>> +                                    /* Per context non-secure context interrupts, 0-1
>interrupts */
>> +                                    <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>, /* for CONTEXT_0
>*/
>> +                                    <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; /* for CONTEXT_1
>*/
>> +                       status = "disabled";
>> +               };
>> +
>> +               clock_cmu: clock-controller at 11C10000 {
>
>Lowercase hex for unit-addresses.
>
>Also, arrange nodes in address order.
>
>> +                       compatible = "tesla,fsd-clock-cmu";
>> +                       reg = <0x0 0x11C10000 0x0 0x3000>;
>> +                       #clock-cells = <1>;
>> +                       clocks = <&fin_pll>;
>> +                       clock-names = "fin_pll";
>> +                       status = "disabled";
>> +               };
>> +
>> +               clock_imem: clock-controller at 10010000 {
>> +                       compatible = "tesla,fsd-clock-imem";
>> +                       reg = <0x0 0x10010000 0x0 0x3000>;
>> +                       #clock-cells = <1>;
>> +                       clocks = <&fin_pll>,
>> +                               <&clock_cmu DOUT_CMU_IMEM_TCUCLK>,
>> +                               <&clock_cmu DOUT_CMU_IMEM_ACLK>,
>> +                               <&clock_cmu DOUT_CMU_IMEM_DMACLK>;
>> +                       clock-names = "fin_pll",
>> +                               "dout_cmu_imem_tcuclk",
>> +                               "dout_cmu_imem_aclk",
>> +                               "dout_cmu_imem_dmaclk";
>> +                       status = "disabled";
>> +               };
>> +
>> +               clock_peric: clock-controller at 14010000 {
>> +                       compatible = "tesla,fsd-clock-peric";
>> +                       reg = <0x0 0x14010000 0x0 0x3000>;
>> +                       #clock-cells = <1>;
>> +                       clocks = <&fin_pll>,
>> +                               <&clock_cmu DOUT_CMU_PLL_SHARED0_DIV4>,
>> +                               <&clock_cmu DOUT_CMU_PERIC_SHARED1DIV36>,
>> +                               <&clock_cmu DOUT_CMU_PERIC_SHARED0DIV3_TBUCLK>,
>> +                               <&clock_cmu DOUT_CMU_PERIC_SHARED0DIV20>,
>> +                               <&clock_cmu
>DOUT_CMU_PERIC_SHARED1DIV4_DMACLK>;
>> +                       clock-names = "fin_pll",
>> +                               "dout_cmu_pll_shared0_div4",
>> +                               "dout_cmu_peric_shared1div36",
>> +                               "dout_cmu_peric_shared0div3_tbuclk",
>> +                               "dout_cmu_peric_shared0div20",
>> +                               "dout_cmu_peric_shared1div4_dmaclk";
>> +                       status = "disabled";
>> +               };
>> +
>> +               clock_fsys0: clock-controller at 15010000 {
>> +                       compatible = "tesla,fsd-clock-fsys0";
>> +                       reg = <0x0 0x15010000 0x0 0x3000>;
>> +                       #clock-cells = <1>;
>> +                       clocks = <&fin_pll>,
>> +                               <&clock_cmu DOUT_CMU_PLL_SHARED0_DIV6>,
>> +                               <&clock_cmu DOUT_CMU_FSYS0_SHARED1DIV4>,
>> +                               <&clock_cmu DOUT_CMU_FSYS0_SHARED0DIV4>;
>> +                       clock-names = "fin_pll",
>> +                               "dout_cmu_pll_shared0_div6",
>> +                               "dout_cmu_fsys0_shared1div4",
>> +                               "dout_cmu_fsys0_shared0div4";
>> +                       status = "disabled";
>> +               };
>> +
>> +               clock_fsys1: clock-controller at 16810000 {
>> +                       compatible = "tesla,fsd-clock-fsys1";
>> +                       reg = <0x0 0x16810000 0x0 0x3000>;
>> +                       #clock-cells = <1>;
>> +                       clocks = <&fin_pll>,
>> +                               <&clock_cmu DOUT_CMU_FSYS1_SHARED0DIV8>,
>> +                               <&clock_cmu DOUT_CMU_FSYS1_SHARED0DIV4>;
>> +                       clock-names = "fin_pll",
>> +                               "dout_cmu_fsys1_shared0div8",
>> +                               "dout_cmu_fsys1_shared0div4";
>> +                       status = "disabled";
>> +               };
>> +
>> +               clock_mfc: clock-controller at 12810000 {
>> +                       compatible = "tesla,fsd-clock-mfc";
>> +                       reg = <0x0 0x12810000 0x0 0x3000>;
>> +                       #clock-cells = <1>;
>> +                       clocks = <&fin_pll>;
>> +                       clock-names = "fin_pll";
>> +                       status = "disabled";
>> +               };
>> +
>> +               clock_csi: clock-controller at 12610000 {
>> +                       compatible = "tesla,fsd-clock-cam_csi";
>> +                       reg = <0x0 0x12610000 0x0 0x3000>;
>> +                       #clock-cells = <1>;
>> +                       clocks = <&fin_pll>;
>> +                       clock-names = "fin_pll";
>> +                       status = "disabled";
>> +               };
>> +
>> +               mdma0: mdma at 10100000 {
>> +                       compatible = "arm,pl330", "arm,primecell";
>> +                       reg = <0x0 0x10100000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #dma-cells = <1>;
>> +                       #dma-channels = <8>;
>> +                       #dma-requests = <32>;
>> +                       clocks = <&clock_imem IMEM_DMA0_IPCLKPORT_ACLK>;
>> +                       clock-names = "apb_pclk";
>> +                       iommus = <&smmu_imem 0x800 0x0>;
>> +                       status = "disabled";
>> +               };
>> +
>> +               mdma1: mdma at 10110000 {
>> +                       compatible = "arm,pl330", "arm,primecell";
>> +                       reg = <0x0 0x10110000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #dma-cells = <1>;
>> +                       #dma-channels = <8>;
>> +                       #dma-requests = <32>;
>> +                       clocks = <&clock_imem IMEM_DMA1_IPCLKPORT_ACLK>;
>> +                       clock-names = "apb_pclk";
>> +                       iommus = <&smmu_imem 0x801 0x0>;
>> +                       status = "disabled";
>> +               };
>> +
>> +               pdma0: pdma at 14280000 {
>> +                       compatible = "arm,pl330", "arm,primecell";
>> +                       reg = <0x0 0x14280000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #dma-cells = <1>;
>> +                       #dma-channels = <8>;
>> +                       #dma-requests = <32>;
>> +                       clocks = <&clock_peric PERIC_DMA0_IPCLKPORT_ACLK>;
>> +                       clock-names = "apb_pclk";
>> +                       iommus = <&smmu_peric 0x2 0x0>;
>> +                       status = "disabled";
>> +               };
>> +
>> +               pdma1: pdma at 14290000 {
>> +                       compatible = "arm,pl330", "arm,primecell";
>> +                       reg = <0x0 0x14290000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #dma-cells = <1>;
>> +                       #dma-channels = <8>;
>> +                       #dma-requests = <32>;
>> +                       clocks = <&clock_peric PERIC_DMA1_IPCLKPORT_ACLK>;
>> +                       clock-names = "apb_pclk";
>> +                       iommus = <&smmu_peric 0x1 0x0>;
>> +                       status = "disabled";
>> +               };
>> +
>> +               mct: mct at 10040000 {
>> +                       compatible = "samsung,exynos4210-mct";
>> +                       reg = <0x0 0x10040000 0x0 0x800>;
>> +                       interrupts = <GIC_SPI 455 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 456 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 457 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 458 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 459 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 460 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 461 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 462 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 463 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 464 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 468 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 469 IRQ_TYPE_LEVEL_HIGH>,
>> +                               <GIC_SPI 470 IRQ_TYPE_LEVEL_HIGH>;
>> +                       clocks = <&fin_pll>, <&clock_imem IMEM_MCT_PCLK>;
>> +                       clock-names = "fin_pll", "mct";
>> +               };
>> +
>> +               serial_0: serial at 14180000 {
>> +                       compatible = "samsung,exynos4210-uart";
>> +                       reg = <0x0 0x14180000 0x0 0x100>;
>> +                       interrupts = <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>;
>> +                       dmas = <&pdma1 0>, <&pdma1 1>;
>> +                       dma-names = "tx", "rx";
>> +                       clocks = <&clock_peric PERIC_PCLK_UART0>,
>> +                                <&clock_peric PERIC_SCLK_UART0>;
>> +                       clock-names = "uart", "clk_uart_baud0";
>> +                       status = "disabled";
>> +               };
>> +
>> +               serial_1: serial at 14190000 {
>> +                       compatible = "samsung,exynos4210-uart";
>> +                       reg = <0x0 0x14190000 0x0 0x100>;
>> +                       interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> +                       dmas = <&pdma1 2>, <&pdma1 3>;
>> +                       dma-names = "tx", "rx";
>> +                       clocks = <&clock_peric PERIC_PCLK_UART1>,
>> +                                <&clock_peric PERIC_SCLK_UART1>;
>> +                       clock-names = "uart", "clk_uart_baud0";
>> +                       status = "disabled";
>> +               };
>> +
>> +               pmu_system_controller: system-controller at 11400000 {
>> +                       compatible = "samsung,exynos7-pmu", "syscon";
>> +                       reg = <0x0 0x11400000 0x0 0x5000>;
>> +               };
>> +
>> +               watchdog_0: watchdog at 100A0000 {
>> +                       compatible = "samsung,exynos7-wdt";
>> +                       reg = <0x0 0x100A0000 0x0 0x100>;
>> +                       interrupts = <GIC_SPI 471 IRQ_TYPE_LEVEL_HIGH>;
>> +                       samsung,syscon-phandle = <&pmu_system_controller>;
>> +                       clocks = <&fin_pll>;
>> +                       clock-names = "watchdog";
>> +                       interrupt-mode = <1>;
>> +               };
>> +
>> +               watchdog_1: watchdog at 100B0000 {
>> +                       compatible = "samsung,exynos7-wdt";
>> +                       reg = <0x0 0x100B0000 0x0 0x100>;
>> +                       interrupts = <GIC_SPI 472 IRQ_TYPE_LEVEL_HIGH>;
>> +                       samsung,syscon-phandle = <&pmu_system_controller>;
>> +                       clocks = <&fin_pll>;
>> +                       clock-names = "watchdog";
>> +                       interrupt-mode = <1>;
>> +               };
>> +
>> +               watchdog_2: watchdog at 100C0000 {
>> +                       compatible = "samsung,exynos7-wdt";
>> +                       reg = <0x0 0x100C0000 0x0 0x100>;
>> +                       interrupts = <GIC_SPI 473 IRQ_TYPE_LEVEL_HIGH>;
>> +                       samsung,syscon-phandle = <&pmu_system_controller>;
>> +                       clocks = <&fin_pll>;
>> +                       clock-names = "watchdog";
>> +                       interrupt-mode = <1>;
>> +               };
>> +
>> +               pwm_0: pwm at 14100000 {
>> +                       compatible = "samsung,exynos4210-pwm";
>> +                       reg = <0x0 0x14100000 0x0 0x100>;
>> +                       samsung,pwm-outputs = <0>, <1>, <2>, <3>;
>> +                       #pwm-cells = <3>;
>> +                       clocks = <&clock_peric PERIC_PWM0_IPCLKPORT_I_PCLK_S0>;
>> +                       clock-names = "timers";
>> +                       status = "disabled";
>> +               };
>> +
>> +               pwm_1: pwm at 14110000 {
>> +                       compatible = "samsung,exynos4210-pwm";
>> +                       reg = <0x0 0x14110000 0x0 0x100>;
>> +                       samsung,pwm-outputs = <0>, <1>, <2>, <3>;
>> +                       #pwm-cells = <3>;
>> +                       clocks = <&clock_peric PERIC_PWM1_IPCLKPORT_I_PCLK_S0>;
>> +                       clock-names = "timers";
>> +                       status = "disabled";
>> +               };
>> +
>> +               hsi2c_0: hsi2c at 14200000 {
>> +                       compatible = "samsung,exynos7-hsi2c";
>> +                       reg = <0x0 0x14200000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 = <&hs_i2c0_bus>;
>> +                       clocks = <&clock_peric PERIC_PCLK_HSI2C0>;
>> +                       clock-names = "hsi2c";
>> +                       status = "disabled";
>> +               };
>> +
>> +               hsi2c_1: hsi2c at 14210000 {
>> +                       compatible = "samsung,exynos7-hsi2c";
>> +                       reg = <0x0 0x14210000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 149 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 = <&hs_i2c1_bus>;
>> +                       clocks = <&clock_peric PERIC_PCLK_HSI2C1>;
>> +                       clock-names = "hsi2c";
>> +                       status = "disabled";
>> +               };
>> +
>> +               hsi2c_2: hsi2c at 14220000 {
>> +                       compatible = "samsung,exynos7-hsi2c";
>> +                       reg = <0x0 0x14220000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 = <&hs_i2c2_bus>;
>> +                       clocks = <&clock_peric PERIC_PCLK_HSI2C2>;
>> +                       clock-names = "hsi2c";
>> +                       status = "disabled";
>> +               };
>> +
>> +               hsi2c_3: hsi2c at 14230000 {
>> +                       compatible = "samsung,exynos7-hsi2c";
>> +                       reg = <0x0 0x14230000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 151 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 = <&hs_i2c3_bus>;
>> +                       clocks = <&clock_peric PERIC_PCLK_HSI2C3>;
>> +                       clock-names = "hsi2c";
>> +                       status = "disabled";
>> +               };
>> +
>> +               hsi2c_4: hsi2c at 14240000 {
>> +                       compatible = "samsung,exynos7-hsi2c";
>> +                       reg = <0x0 0x14240000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 = <&hs_i2c4_bus>;
>> +                       clocks = <&clock_peric PERIC_PCLK_HSI2C4>;
>> +                       clock-names = "hsi2c";
>> +                       status = "disabled";
>> +               };
>> +
>> +               hsi2c_5: hsi2c at 14250000 {
>> +                       compatible = "samsung,exynos7-hsi2c";
>> +                       reg = <0x0 0x14250000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 = <&hs_i2c5_bus>;
>> +                       clocks = <&clock_peric PERIC_PCLK_HSI2C5>;
>> +                       clock-names = "hsi2c";
>> +                       status = "disabled";
>> +               };
>> +
>> +               hsi2c_6: hsi2c at 14260000 {
>> +                       compatible = "samsung,exynos7-hsi2c";
>> +                       reg = <0x0 0x14260000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 = <&hs_i2c6_bus>;
>> +                       clocks = <&clock_peric PERIC_PCLK_HSI2C6>;
>> +                       clock-names = "hsi2c";
>> +                       status = "disabled";
>> +               };
>> +
>> +               hsi2c_7: hsi2c at 14270000 {
>> +                       compatible = "samsung,exynos7-hsi2c";
>> +                       reg = <0x0 0x14270000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 = <&hs_i2c7_bus>;
>> +                       clocks = <&clock_peric PERIC_PCLK_HSI2C7>;
>> +                       clock-names = "hsi2c";
>> +                       status = "disabled";
>> +               };
>> +       };
>> +};
>> --
>> 2.17.1
>>




More information about the linux-arm-kernel mailing list