[PATCH v4] soc: ti: smartreflex: Use platform_get_irq_optional() to get the interrupt

Andy Shevchenko andy.shevchenko at gmail.com
Tue Jan 4 06:48:35 PST 2022


On Tue, Jan 4, 2022 at 3:45 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj at bp.renesas.com> wrote:
>
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq_optional().
>
> While at it return 0 instead of returning ret in the probe success path.

...

> +       ret = platform_get_irq_optional(pdev, 0);
> +       if (ret < 0 && ret != -ENXIO) {

> +               dev_err_probe(&pdev->dev, ret, "%s: failed to get IRQ resource\n", __func__);
> +               return ret;

return dev_err_probe(...); ?

> +       }

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list