[PATCH v4 2/8] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device

John Garry john.garry at huawei.com
Thu Feb 24 04:32:59 PST 2022


On 24/02/2022 03:53, Yicong Yang wrote:
> On 2022/2/22 19:06, John Garry wrote:
>> On 21/02/2022 08:43, Yicong Yang wrote:
>>> HiSilicon PCIe tune and trace device(PTT) is a PCIe Root Complex
>>> integrated Endpoint(RCiEP) device, providing the capability
>>> to dynamically monitor and tune the PCIe traffic, and trace
>>> the TLP headers.
>>>
>>> Add the driver for the device to enable the trace function.
>>> This patch adds basic function of trace, including the device's
>>> probe and initialization, functions for trace buffer allocation
>>> and trace enable/disable, register an interrupt handler to
>>> simply response to the DMA events. The user interface of trace
>>> will be added in the following patch.
>>>
>>
>> Fill commit message lines upto 75 characters
> 
> Hi John,
> 
> Thanks for the comments.
> 
> The commit message is within 75 characters. I checked again and checkpatch
> didn't warning for this.

I mean to fill the lines up as much as possible, upto 75 char max, if 
not already done so. I am not sure if you are doing this already, but it 
looks like you were not.

Checkpatch
will
no
warn
about
a
commit
message
like
this
:)


Thanks,
john



More information about the linux-arm-kernel mailing list