[PATCH] arm: mmu: fix returns from early_param() and __setup() functions

Randy Dunlap rdunlap at infradead.org
Wed Feb 23 11:46:35 PST 2022


early_param() handlers should return 0 on success.
__setup() handlers should return 1 on success, i.e., the parameter
has been handled. A return of 0 would cause the "option=value" string
to be added to init's environment strings, polluting it.

../arch/arm/mm/mmu.c: In function 'test_early_cachepolicy':
../arch/arm/mm/mmu.c:215:1: error: no return statement in function returning non-void [-Werror=return-type]
../arch/arm/mm/mmu.c: In function 'test_noalign_setup':
../arch/arm/mm/mmu.c:221:1: error: no return statement in function returning non-void [-Werror=return-type]

Fixes: b849a60e0903 ("ARM: make cr_alignment read-only #ifndef CONFIG_CPU_CP15")
Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
Reported-by: Igor Zhbanov <i.zhbanov at omprussia.ru>
Cc: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Cc: Russell King <linux at armlinux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
Cc: patches at armlinux.org.uk
---
KernelVersion: v5.16

 arch/arm/mm/mmu.c |    2 ++
 1 file changed, 2 insertions(+)

--- next-2022-0222.orig/arch/arm/mm/mmu.c
+++ next-2022-0222/arch/arm/mm/mmu.c
@@ -212,12 +212,14 @@ early_param("ecc", early_ecc);
 static int __init early_cachepolicy(char *p)
 {
 	pr_warn("cachepolicy kernel parameter not supported without cp15\n");
+	return 0;
 }
 early_param("cachepolicy", early_cachepolicy);
 
 static int __init noalign_setup(char *__unused)
 {
 	pr_warn("noalign kernel parameter not supported without cp15\n");
+	return 1;
 }
 __setup("noalign", noalign_setup);
 



More information about the linux-arm-kernel mailing list