[PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error

Ivan Bornyakov i.bornyakov at metrotek.ru
Tue Feb 22 22:58:15 PST 2022


On Wed, Feb 23, 2022 at 11:51:45AM +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
> 
> Signed-off-by: Wan Jiabing <wanjiabing at vivo.com>
> ---
>  drivers/bus/imx-weim.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 60fbd42041dd..2ea0a51f79f6 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -352,8 +352,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
>  
>  		pdev = of_find_device_by_node(rd->dn);
>  		if (!pdev) {
> -			dev_err(&pdev->dev,
> -				"Could not find platform device for '%pOF'\n",
> +			pr_err("Could not find platform device for '%pOF'\n",
>  				rd->dn);
>  
>  			ret = notifier_from_errno(-EINVAL);
> -- 
> 2.35.1
> 

Acked-by: Ivan Bornyakov <i.bornyakov at metrotek.ru>




More information about the linux-arm-kernel mailing list