[PATCH] soc: fujitsu: Add A64FX diagnostic interrupt driver

hasegawa-hitomi at fujitsu.com hasegawa-hitomi at fujitsu.com
Tue Feb 22 02:52:30 PST 2022


Hi Arnd.

> Is panic() the best action for this? I'm not familiar with this feature, but
> it sounds like handle_sysrq() might be more appropriate. How does a
> user trigger the event, and is there any sideband data that can be
> sent along with the interrupt?

This event is triggered by sending "$ ipmitool chassis power diag" to the BMC.
It does not send any data when it interrupts.
Use sysrq can enable to the user to control enable/disable, it seems better
to use handle_sysrq().

> Normal driver code should use readl()/writel(), not
> readl_relaxed()/writel_relaxed().
> If you do need the relaxed versions, please add a comment explaining why,
> otherwise change the code here and below.

Okay, I will correct it as indicated.

Thank you for pointing out the problem. I will release v2 which fixes
the problem.

Hitomi Hasegawa



More information about the linux-arm-kernel mailing list