(EXT) Re: [PATCH 2/5] ARM: dts: imx6ul: add TQ-Systems MBa6ULx device trees

Shawn Guo shawnguo at kernel.org
Mon Feb 21 18:14:10 PST 2022


On Mon, Feb 21, 2022 at 04:45:58PM +0100, Alexander Stein wrote:
...
> > > diff --git a/arch/arm/boot/dts/mba6ulx.dtsi
> > > b/arch/arm/boot/dts/mba6ulx.dtsi new file mode 100644
> > > index 000000000000..3a35b1efdc1f
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/mba6ulx.dtsi
> > > @@ -0,0 +1,615 @@
> > > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> > > +/*
> > > + * Copyright 2018-2022 TQ-Systems GmbH
> > > + * Author: Markus Niebel <Markus.Niebel at tq-group.com>
> > > + */
> > > +
> > > +/ {
> > > +	model = "TQ-Systems MBA6ULx Baseboard";
> > > +
> > > +	aliases {
> > > +		mmc0 = &usdhc2;
> > > +		mmc1 = &usdhc1;
> > > +		rtc0 = &rtc0;
> > > +		rtc1 = &snvs_rtc;
> > > +	};
> > > +
> > > +	backlight: backlight {
> > > +		compatible = "pwm-backlight";
> > > +		power-supply = <&reg_mba6ul_3v3>;
> > > +		enable-gpios = <&expander_out0 4 GPIO_ACTIVE_HIGH>;
> > > +		status = "disabled";
> > > +	};
> > > +
> > > +	beeper: beeper {
> > > +		compatible = "gpio-beeper";
> > > +		gpios = <&expander_out1 6 GPIO_ACTIVE_HIGH>;
> > > +	};
> > > +
> > > +	chosen {
> > > +		stdout-path = &uart1;
> > > +	};
> > 
> > Move 'chosen' node up.
> 
> Ok. The binding does not say anything regarding the order with respect to the 
> alias node. I've seen examples of both order. So I went with alias 1st, chosen 
> 2nd.

Sorry for not being clear, but I was asking to put 'chosen' before
backlight and beeper nodes.

Shawn



More information about the linux-arm-kernel mailing list