[PATCH] soc: imx: gpcv2: Fix clock disabling imbalance in error path

Shawn Guo shawnguo at kernel.org
Sun Feb 20 23:38:16 PST 2022


On Mon, Feb 21, 2022 at 08:29:24AM +0200, Laurent Pinchart wrote:
> Hello Shawn,
> 
> On Mon, Feb 21, 2022 at 01:59:29PM +0800, Shawn Guo wrote:
> > On Fri, Feb 18, 2022 at 11:57:20PM +0200, Laurent Pinchart wrote:
> > > The imx_pgc_power_down() starts by enabling the domain clocks, and thus
> > > disables them in the error path. Commit 18c98573a4cf ("soc: imx: gpcv2:
> > > add domain option to keep domain clocks enabled") made the clock enable
> > > conditional, but forgot to add the same condition to the error path.
> > > This can result in a clock enable/disable imbalance. Fix it.
> > > 
> > > Fixes: 18c98573a4cf ("soc: imx: gpcv2: add domain option to keep domain clocks enabled")
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > 
> > Applied, thanks!
> 
> Thank you.
> 
> I've noticed that Lucas' reviewed-by tag didn't end up in the commit in
> your imx/fixes branch. Depending on your rebase policy with that branch,
> you may want to ammend the commit.

Oops!  Thanks for reminding, Laurent!  Fixed.

Shawn



More information about the linux-arm-kernel mailing list