[PATCH] net: ll_temac: check the return value of devm_kmalloc()
xkernel.wang at foxmail.com
xkernel.wang at foxmail.com
Wed Feb 16 02:46:42 PST 2022
From: Xiaoke Wang <xkernel.wang at foxmail.com>
devm_kmalloc() returns a pointer to allocated memory on success, NULL
on failure. While lp->indirect_lock is allocated by devm_kmalloc()
without proper check. It is better to check the value of it to
prevent potential wrong memory access.
Signed-off-by: Xiaoke Wang <xkernel.wang at foxmail.com>
---
drivers/net/ethernet/xilinx/ll_temac_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 463094c..7c5dd39 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -1427,6 +1427,11 @@ static int temac_probe(struct platform_device *pdev)
lp->indirect_lock = devm_kmalloc(&pdev->dev,
sizeof(*lp->indirect_lock),
GFP_KERNEL);
+ if (!lp->indirect_lock) {
+ dev_err(&pdev->dev,
+ "indirect register lock allocation failed\n");
+ return -ENOMEM;
+ }
spin_lock_init(lp->indirect_lock);
}
--
More information about the linux-arm-kernel
mailing list