(EXT) Re: [PATCH 4/8] ARM: dts: imx6ul: fix adc node compatible

[Alexander Stein]

Am Freitag, 11. Februar 2022, 04:47:07 CET schrieb Shawn Guo:
> On Tue, Jan 25, 2022 at 02:50:10PM +0100, Alexander Stein wrote:
> > fsl,imx6ul-adc is not listed in the binding, so remove it. Fixes the
> > dt_binding_check warning:
> > adc at 2198000: compatible:0: 'fsl,vf610-adc' was expected
> > adc at 2198000: compatible: ['fsl,imx6ul-adc', 'fsl,vf610-adc'] is too long
> > adc at 2198000: compatible: Additional items are not allowed ('fsl,vf610-adc'
> > was unexpected)
> > 
> > Signed-off-by: Alexander Stein <alexander.stein at ew.tq-group.com>
> > ---
> > 
> >  arch/arm/boot/dts/imx6ul.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> > index df8b4ad62418..d6c2b0ad3eac 100644
> > --- a/arch/arm/boot/dts/imx6ul.dtsi
> > +++ b/arch/arm/boot/dts/imx6ul.dtsi
> > @@ -920,7 +920,7 @@ usdhc2: mmc at 2194000 {
> > 
> >  			};
> >  			
> >  			adc1: adc at 2198000 {
> > 
> > -				compatible = "fsl,imx6ul-adc", 
"fsl,vf610-adc";
> > +				compatible = "fsl,vf610-adc";
> 
> Maybe we should add compatible "fsl,imx6ul-adc" to bindings?

In this case "fsl,imx6sx-adc" has to be added as well. I'll do it in a v2.

Regards,
Alexander

> >  				reg = <0x02198000 0x4000>;
> >  				interrupts = <GIC_SPI 100 
IRQ_TYPE_LEVEL_HIGH>;
> >  				clocks = <&clks IMX6UL_CLK_ADC1>;