[PATCH v3 5/7] sched/preempt: add PREEMPT_DYNAMIC using static keys

Frederic Weisbecker frederic at kernel.org
Thu Feb 10 07:59:29 PST 2022


On Thu, Feb 10, 2022 at 10:27:39AM +0000, Mark Rutland wrote:
> On Wed, Feb 09, 2022 at 06:48:01PM +0100, Frederic Weisbecker wrote:
> > On Wed, Feb 09, 2022 at 03:35:33PM +0000, Mark Rutland wrote:
> > > +config HAVE_PREEMPT_DYNAMIC_KEY
> > > +	bool
> > > +	depends on JUMP_LABEL
> > 
> > This should probably be:
> > 
> >      depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO
> >      select JUMP_LABEL
> > 
> > Otherwise you may run into trouble if CONFIG_JUMP_LABEL is initially n.
> 
> I'll make that:
> 
>  config HAVE_PREEMPT_DYNAMIC_KEY
>         bool
>         depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO
>         ...
> 
> ... and 
> 
>  config PREEMPT_DYNAMIC
>         bool "Preemption behaviour defined on boot"
>         depends on HAVE_PREEMPT_DYNAMIC && !PREEMPT_RT
>         select JUMP_LABEL if HAVE_PREEMPT_DYNAMIC_KEY
>         ...
> 
> So that we don't force JUMP_LABEL on even when people aren't using it.

Much better!

Thanks!



More information about the linux-arm-kernel mailing list