[PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit

Andy Shevchenko andy.shevchenko at gmail.com
Thu Feb 10 03:13:28 PST 2022


On Thu, Feb 10, 2022 at 12:54 PM <davidcomponentone at gmail.com> wrote:
>
> From: Yang Guang <yang.guang5 at zte.com.cn>
>
> coccinelle report:
> ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
> WARNING: use scnprintf or sprintf
> ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
> WARNING: use scnprintf or sprintf
> ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
> WARNING: use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.

sysfs_emit()
scnprintf()
sprintf()

...

> CC: David Yang <davidcomponentone at gmail.com>

> - Use the CC for patch sender

This is incorrect. The submitter must have (the last) SoB tag.
Question was about authorship just to be clear.

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list