[PATCH] perf/arm-cmn: Make arm_cmn_debugfs static

Anshuman Khandual anshuman.khandual at arm.com
Thu Feb 3 21:18:46 PST 2022



On 2/3/22 11:31 PM, Robin Murphy wrote:
> Indeed our debugfs directory is driver-internal so should be static.

True.

> 
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Robin Murphy <robin.murphy at arm.com>
> ---
>  drivers/perf/arm-cmn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index 0e48adce57ef..d0e1ce2c83ba 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
> @@ -353,7 +353,7 @@ static struct arm_cmn_node *arm_cmn_node(const struct arm_cmn *cmn,
>  	return NULL;
>  }
>  
> -struct dentry *arm_cmn_debugfs;
> +static struct dentry *arm_cmn_debugfs;
>  
>  #ifdef CONFIG_DEBUG_FS
>  static const char *arm_cmn_device_type(u8 type)
> 

Reviewed-by: Anshuman Khandual <anshuman.khandual at arm.com>



More information about the linux-arm-kernel mailing list