[PATCH 1/8] ARM: ftrace: ensure that ADR take Thumb bit into account

Linus Walleij linus.walleij at linaro.org
Wed Feb 2 15:53:38 PST 2022


On Tue, Jan 25, 2022 at 4:37 PM Ard Biesheuvel <ardb at kernel.org> wrote:

> Using ADR to take the address of 'ftrace_stub' via a local label
> produces an address that has the Thumb bit cleared, which means the
> subsequent comparison is guaranteed to fail. Instead, use the badr
> macro, which forces the Thumb bit to be set.
>
> Fixes: a3ba87a61499 ("ARM: 6316/1: ftrace: add Thumb-2 support")
> Signed-off-by: Ard Biesheuvel <ardb at kernel.org>

Looks correct to me!
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list