[PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Wed Dec 21 04:30:12 PST 2022


On 21/12/2022 13:28, Andrei Stefanescu wrote:
> Hi Chester,
> 
>> +patternProperties:
>> +  '-pins$':
> 
> Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins.

You cannot have underscores as node names, so what do you mean here? You
need to fix your DTS not introduce bad practices to mainline kernel.

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list