[PATCH v2] arm64: dts: imx8mp: Add Hantro G1, G2 DT nodes

[Lucas Stach]

Am Montag, dem 19.12.2022 um 20:15 +0100 schrieb Marek Vasut:
> On 12/19/22 18:50, Lucas Stach wrote:
> > Am Sonntag, dem 18.12.2022 um 05:20 +0100 schrieb Marek Vasut:
> > > Add DT nodes for the Hantro VPU found in i.MX8MP SoC.
> > > 
> > > Signed-off-by: Marek Vasut <marex at denx.de>
> > > ---
> > > Cc: Abel Vesa <abel.vesa at nxp.com>
> > > Cc: Adam Ford <aford173 at gmail.com>
> > > Cc: Alexander Stein <alexander.stein at ew.tq-group.com>
> > > Cc: Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>
> > > Cc: Fabio Estevam <festevam at gmail.com>
> > > Cc: Jacky Bai <ping.bai at nxp.com>
> > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>
> > > Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > Cc: Lucas Stach <l.stach at pengutronix.de>
> > > Cc: Marek Vasut <marex at denx.de>
> > > Cc: Markus Niebel <Markus.Niebel at ew.tq-group.com>
> > > Cc: NXP Linux Team <linux-imx at nxp.com>
> > > Cc: Peng Fan <peng.fan at nxp.com>
> > > Cc: Pengutronix Kernel Team <kernel at pengutronix.de>
> > > Cc: Richard Cochran <richardcochran at gmail.com>
> > > Cc: Richard Zhu <hongxing.zhu at nxp.com>
> > > Cc: Rob Herring <robh+dt at kernel.org>
> > > Cc: Sascha Hauer <s.hauer at pengutronix.de>
> > > Cc: Shawn Guo <shawnguo at kernel.org>
> > > To: linux-arm-kernel at lists.infradead.org
> > > ---
> > > V2: Drop the VC8000E
> > > ---
> > >   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 25 +++++++++++++++++++++++
> > >   1 file changed, 25 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > index 34c2c80c47eb5..d472170ee9ff1 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > @@ -1639,6 +1639,28 @@ gpu2d: gpu at 38008000 {
> > >   			power-domains = <&pgc_gpu2d>;
> > >   		};
> > >   
> > > +		vpu_g1: video-codec at 38300000 {
> > > +			compatible = "nxp,imx8mm-vpu-g1";
> > > +			reg = <0x38300000 0x10000>;
> > > +			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > > +			clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
> > > +			assigned-clocks = <&clk IMX8MP_CLK_VPU_G1>;
> > > +			assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
> > > +			assigned-clock-rates = <700000000>;
> > 
> > Where does this clock rate come from? G1 nominal rate is 600MHz,
> 
> NXP downstream, see:
> 
> https://source.codeaurora.org/external/imx/linux-imx/tree/arch/arm64/boot/dts/freescale/imx8mp.dtsi?h=lf-5.15.y#n2231

Nope, as you can see, downstream is running all clocks at the overdrive
rates: G1 at 800MHz, G2 at 700MHz, bus at 800MHz. That is quite
different from all 3 clocks at 700MHz from your patch.

Regards,
Lucas