[PATCH v3 2/2] drm/imx/lcdc: Implement DRM driver for imx21

Philipp Zabel p.zabel at pengutronix.de
Mon Dec 19 01:59:19 PST 2022


On Fr, 2022-12-16 at 18:50 +0100, Uwe Kleine-König wrote:
[...]
> +static int imx_lcdc_pipe_check(struct drm_simple_display_pipe *pipe,
> +			       struct drm_plane_state *plane_state,
> +			       struct drm_crtc_state *crtc_state)
> +{
> +	const struct drm_display_mode *mode = &crtc_state->mode;
> +	const struct drm_display_mode *old_mode = &pipe->crtc.state->mode;
> +
> +	if (mode->hdisplay < LCDC_MIN_XRES || mode->hdisplay > LCDC_MAX_XRES ||
> +	    mode->vdisplay < LCDC_MIN_YRES || mode->vdisplay > LCDC_MAX_YRES ||
> +	    mode->hdisplay & 0x10) { /* must be multiple of 16 */
> +		drm_err(pipe->crtc.dev, "unsupported display mode (%u x %u)\n",
> +			  mode->hdisplay, mode->vdisplay);
			^^
Nitpick: now superfluous whitespace.

regards
Philipp



More information about the linux-arm-kernel mailing list