[PATCH v2 2/3] dt-bindings: iio: adc: Add binding documentation for NXP IMX93 ADC
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Mon Dec 19 00:59:08 PST 2022
On 19/12/2022 09:52, Bough Chen wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>> Sent: 2022年12月15日 18:12
>> To: Bough Chen <haibo.chen at nxp.com>; jic23 at kernel.org; lars at metafoo.de;
>> robh+dt at kernel.org; krzysztof.kozlowski+dt at linaro.org;
>> shawnguo at kernel.org; s.hauer at pengutronix.de; kernel at pengutronix.de
>> Cc: festevam at gmail.com; dl-linux-imx <linux-imx at nxp.com>;
>> linux-iio at vger.kernel.org; devicetree at vger.kernel.org;
>> linux-arm-kernel at lists.infradead.org
>> Subject: Re: [PATCH v2 2/3] dt-bindings: iio: adc: Add binding documentation for
>> NXP IMX93 ADC
>>
>> On 14/12/2022 14:35, haibo.chen at nxp.com wrote:
>>> From: Haibo Chen <haibo.chen at nxp.com>
>>>
>>> The IMX93 SoC has a new ADC IP, so add binding documentation for NXP
>>> IMX93 ADC.
>>>
>>> Signed-off-by: Haibo Chen <haibo.chen at nxp.com>
>>> ---
>>> .../bindings/iio/adc/nxp,imx93-adc.yaml | 79
>> +++++++++++++++++++
>>> 1 file changed, 79 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
>>> b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
>>> new file mode 100644
>>> index 000000000000..229bb79e255c
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
>>
>> This was already sent, so I am surprised to see this in worse or the same state.
>> Don't force us to repeat review, it's a waste of time.
>
> Sorry, I'm focus on the driver side, will pay much attention on the yaml binding.
>
> By the way, for your first review comments:
>
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + clock-names:
> > + const: ipg
>
> No need for clock-names in such case.
I think this was for the other patch and recommendation was to drop
entire clock-names. Here you do not have it, so no need to change this.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list