[PATCH 3/7] staging: vc04_services: Drop VCHIQ_ERROR usage

Stefan Wahren stefan.wahren at i2se.com
Thu Dec 15 03:30:29 PST 2022


Hi Umang,

thanks for taking care of this.

Am 15.12.22 um 07:58 schrieb Umang Jain:
> Drop the usage of VCHIQ_ERROR vchiq_status enum type. Replace it with
> -EINVAL to report the error.

I would prefer to use adequate error codes like ENOMEM and so on. I 
agree simply replacing all VCHIQ_ERROR with -EINVAL is easier, but 
wasn't the real intention of the TODO item.

The rest of the series looks good to me.

Best regards




More information about the linux-arm-kernel mailing list