[PATCH 4/4] soc: imx: imx8mp-blk-ctrl: expose high performance PLL clock

[Marcel Ziswiler]

On Wed, 2022-12-14 at 04:40 +0800, kernel test robot wrote:
> Hi Lucas,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on robh/for-next]
> [also build test WARNING on shawnguo/for-next krzk/for-next krzk-dt/for-next linus/master v6.1 next-20221213]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:   
> https://github.com/intel-lab-lkp/linux/commits/Lucas-Stach/dt-bindings-soc-imx8mp-hsio-blk-ctrl-add-clock-cells/20221214-000245
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> patch link:    https://lore.kernel.org/r/20221213160112.1900410-4-l.stach%40pengutronix.de
> patch subject: [PATCH 4/4] soc: imx: imx8mp-blk-ctrl: expose high performance PLL clock
> config: m68k-allyesconfig

Yeah, our Gitlab CI gave me the same even for e.g. imx_v6_v7_defconfig:

drivers/soc/imx/imx8mp-blk-ctrl.c: In function 'clk_hsio_pll_prepare':
1765drivers/soc/imx/imx8mp-blk-ctrl.c:105:7: error: implicit declaration of function 'FIELD_PREP' [-
Werror=implicit-function-declaration]
1766  105 |       FIELD_PREP(P_PLL_MASK, 12) |
1767      |       ^~~~~~~~~~

> compiler: m68k-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/5046774c03a3496c19069b9237fee85273c215aa
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Lucas-Stach/dt-bindings-soc-imx8mp-hsio-blk-ctrl-add-clock-
> cells/20221214-000245
>         git checkout 5046774c03a3496c19069b9237fee85273c215aa
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k
> SHELL=/bin/bash drivers/soc/
> 
> If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp at intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/soc/imx/imx8mp-blk-ctrl.c: In function 'clk_hsio_pll_prepare':
>    drivers/soc/imx/imx8mp-blk-ctrl.c:105:28: error: implicit declaration of function 'FIELD_PREP' [-
> Werror=implicit-function-declaration]
>      105 |                            FIELD_PREP(P_PLL_MASK, 12) |
>          |                            ^~~~~~~~~~
>    drivers/soc/imx/imx8mp-blk-ctrl.c: At top level:
> > > drivers/soc/imx/imx8mp-blk-ctrl.c:146:5: warning: no previous prototype for 'imx8mp_hsio_blk_ctrl_probe'
> > > [-Wmissing-prototypes]
>      146 | int imx8mp_hsio_blk_ctrl_probe(struct imx8mp_blk_ctrl *bc)
>          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 
> 
> vim +/imx8mp_hsio_blk_ctrl_probe +146 drivers/soc/imx/imx8mp-blk-ctrl.c
> 
>    145  
>  > 146  int imx8mp_hsio_blk_ctrl_probe(struct imx8mp_blk_ctrl *bc)
>    147  {
>    148          struct clk_hsio_pll *clk_hsio_pll;
>    149          struct clk_hw *hw;
>    150          struct clk_init_data init = {};
>    151          int ret;
>    152  
>    153          printk("%s\n", __func__);
>    154  
>    155          clk_hsio_pll = devm_kzalloc(bc->dev, sizeof(*clk_hsio_pll), GFP_KERNEL);
>    156          if (!clk_hsio_pll)
>    157                  return -ENOMEM;
>    158  
>    159          init.name = "hsio_pll";
>    160          init.ops = &clk_hsio_pll_ops;
>    161          init.parent_names = (const char *[]){"osc_24m"};
>    162          init.num_parents = 1;
>    163  
>    164          clk_hsio_pll->regmap = bc->regmap;
>    165          clk_hsio_pll->hw.init = &init;
>    166  
>    167          hw = &clk_hsio_pll->hw;
>    168          ret = devm_clk_hw_register(bc->dev, hw);
>    169          if (ret)
>    170                  return ret;
>    171  
>    172          return devm_of_clk_add_hw_provider(bc->dev, of_clk_hw_simple_get, hw);
>    173  }
>    174