[PATCH] thermal: imx_sc_thermal: Drop empty platform remove function

[Marco Felsch]

Hi Daniel,

On 22-12-13, Daniel Lezcano wrote:
> On 12/12/2022 23:02, Uwe Kleine-König wrote:
> > A remove callback just returning 0 is equivalent to no remove callback
> > at all. So drop the useless function.
> 
> AFAIU, without the remove callback the module can not be unloaded, no?

This should be unrelated according:
https://elixir.bootlin.com/linux/latest/source/drivers/base/platform.c#L1419

Regards,
  Marco


> 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > ---
> >   drivers/thermal/imx_sc_thermal.c | 6 ------
> >   1 file changed, 6 deletions(-)
> > 
> > diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> > index 5d92b70a5d53..4df925e3a80b 100644
> > --- a/drivers/thermal/imx_sc_thermal.c
> > +++ b/drivers/thermal/imx_sc_thermal.c
> > @@ -127,11 +127,6 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
> >   	return 0;
> >   }
> > -static int imx_sc_thermal_remove(struct platform_device *pdev)
> > -{
> > -	return 0;
> > -}
> > -
> >   static int imx_sc_sensors[] = { IMX_SC_R_SYSTEM, IMX_SC_R_PMIC_0, -1 };
> >   static const struct of_device_id imx_sc_thermal_table[] = {
> > @@ -142,7 +137,6 @@ MODULE_DEVICE_TABLE(of, imx_sc_thermal_table);
> >   static struct platform_driver imx_sc_thermal_driver = {
> >   		.probe = imx_sc_thermal_probe,
> > -		.remove	= imx_sc_thermal_remove,
> >   		.driver = {
> >   			.name = "imx-sc-thermal",
> >   			.of_match_table = imx_sc_thermal_table,
> > 
> > base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
> 
> -- 
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
> 
> 
>