[PATCH] iommu/sun50i: Remove IOMMU_DOMAIN_IDENTITY

Joerg Roedel joro at 8bytes.org
Mon Dec 5 02:53:16 PST 2022


On Mon, Nov 28, 2022 at 10:06:28AM -0400, Jason Gunthorpe wrote:
> This driver treats IOMMU_DOMAIN_IDENTITY the same as UNMANAGED, which
> cannot possibly be correct.
> 
> UNMANAGED domains are required to start out blocking all DMAs. This seems
> to be what this driver does as it allocates a first level 'dt' for the IO
> page table that is 0 filled.
> 
> Thus UNMANAGED looks like a working IO page table, and so IDENTITY must be
> a mistake. Remove it.
> 
> Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver")
> Signed-off-by: Jason Gunthorpe <jgg at nvidia.com>

Applied, thanks.




More information about the linux-arm-kernel mailing list