[PATCH 2/4] arm64: dts: ti: j721e*: Define aliases in board files

[Arnd Bergmann]

On Tue, Aug 30, 2022, at 5:21 PM, Nishanth Menon wrote:
> Define aliases in board files, instead of in the SoC dtsi file.
>
> Reported-by: Daniel Thompson <daniel.thompson at linaro.org>
> Signed-off-by: Nishanth Menon <nm at ti.com>

The patch is a good step in the right direction, but

> 
> +	aliases {
> +		serial0 = &wkup_uart0;
> +		serial1 = &mcu_uart0;
> +		serial2 = &main_uart0;
> +		serial3 = &main_uart1;
> +		serial4 = &main_uart2;
> +		serial5 = &main_uart3;
> +		serial6 = &main_uart4;
> +		serial7 = &main_uart5;
> +		serial8 = &main_uart6;
> +		serial9 = &main_uart7;
> +		serial10 = &main_uart8;
> +		serial11 = &main_uart9;
> +		ethernet0 = &cpsw_port1;
> +		mmc0 = &main_sdhci0;
> +		mmc1 = &main_sdhci1;
> +		mmc2 = &main_sdhci2;

Are all these devices actually used on both of the boards?

There is no point in defining an alias if the board
does not route these to a device or a connector.

      Arnd