kmemleak: Cannot insert 0xffffff806e24f000 into the object search tree (overlaps existing) [RPi CM4]

[Greg Kroah-Hartman]

On Wed, Aug 17, 2022 at 06:02:47PM +0100, Catalin Marinas wrote:
> On Wed, Aug 17, 2022 at 06:52:35PM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Aug 17, 2022 at 05:01:50PM +0200, Marco Elver wrote:
> > > On Wed, 17 Aug 2022 at 10:23, Catalin Marinas <catalin.marinas at arm.com> wrote:
> > > > On Wed, Aug 17, 2022 at 08:25:06AM +0200, Greg Kroah-Hartman wrote:
> > > > > On Tue, Aug 16, 2022 at 04:39:43PM -0700, Andrew Morton wrote:
> > > > > > On Tue, 16 Aug 2022 15:26:29 +0100 Will Deacon <will at kernel.org> wrote:
> > > > > >
> > > > > > > On Tue, Aug 16, 2022 at 10:52:19AM +0000, Yee Lee (李建誼) wrote:
> > > > > > > > The kfence patch(07313a2b29ed) is based on the prior changes in
> > > > > > > > kmemleak(0c24e061196c2 , merged in v6.0-rc1), but it shows up earlier in
> > > > > > > > v5.19.
> > > > > > > >
> > > > > > > > @akpm
> > > > > > > > Andrew, sorry that the short fix tag caused confusing. Can we pull out the
> > > > > > > > patch(07313a2b29e) in v5.19.x?
> > > > > > > >
> > > > > > > > Kfence: (07313a2b29ed) https://github.com/torvalds/linux/commit/07313a2b29ed1079eaa7722624544b97b3ead84b
> > > > > > > > Kmemleak: (0c24e061196c2) https://github.com/torvalds/linux/commit/0c24e061196c21d53328d60f4ad0e5a2b3183343
> > > > > > >
> > > > > > > Hmm, so if I'm understanding correctly then:
> > > > > > >
> > > > > > >  - The kfence fix (07313a2b29ed) depends on a kmemleak change (0c24e061196c2)
> > > > > > >    but the patches apply cleanly on their own.
> > > > > > >
> > > > > > >  - The kmemleak change landed in the v6.0 merge window, but the kfence fix
> > > > > > >    landed in 5.19 (and has a fixes tag)
> > > > > > >
> > > > > > > So it sounds like we can either:
> > > > > > >
> > > > > > >  1. Revert 07313a2b29ed in the stable trees which contain it and then fix
> > > > > > >     the original issue some other way.
> > > > > >
> > > > > > 07313a2b29ed should not be in the stable tree.  It did not have a
> > > > > > cc:stable and we've asked the stable tree maintainers not to blindly
> > > > > > backport everything that has a Fixes: tag.
> > > > > >
> > > > > > How did this happen?
> > > > >
> > > > > I do not see 07313a2b29ed in any stable tree or release that I can
> > > > > find, am I missing something?
> > > >
> > > > I think commit 07313a2b29ed went in mainline 5.19, see this merge:
> > > > 39c3c396f813 ("Merge tag 'mm-hotfixes-stable-2022-07-26' of
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm"). So there was no
> > > > stable involvement.
> > > 
> > > I sent the revert as a PATCH for 5.19.y here:
> > > https://lore.kernel.org/all/20220816163641.2359996-1-elver@google.com/
> > 
> > Why do we need a revert here but not one for Linus's tree?
> 
> This commit was meant as a fix for 0c24e061196c21d5 ("mm: kmemleak: add
> rbtree and store physical address for objects allocated with PA") which
> only made it into 6.0-rc1. But it ended up in 5.19 without the commit it
> was fixing.

Ah, that's why the Fixes: tag was referencing a commit in the "future".

{sigh}

I'll go queue this up now, thanks.

greg k-h