[PATCH v2] media: rockchip: rga: Fix probe rga_parse_dt bugs

Jarrah Gosbell kernel at undef.tools
Mon Aug 15 03:36:22 PDT 2022


From: Ondrej Jirman <megi at xff.cz>

rga_parse_dt is missing a error return, so if some of the resources
return DEFER_PROBE, probe will succeed without these resources.

Signed-off-by: Ondrej Jirman <megi at xff.cz>
Co-developed-by: Jarrah Gosbell <kernel at undef.tools>
Signed-off-by: Jarrah Gosbell <kernel at undef.tools>
---
v1 -> v2: use dev_err_probe to handle -EPROBE_DEFER.

 drivers/media/platform/rockchip/rga/rga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
index 2f8df74ad0fd..61b25fcf826e 100644
--- a/drivers/media/platform/rockchip/rga/rga.c
+++ b/drivers/media/platform/rockchip/rga/rga.c
@@ -816,7 +816,7 @@ static int rga_probe(struct platform_device *pdev)
 
 	ret = rga_parse_dt(rga);
 	if (ret)
-		dev_err(&pdev->dev, "Unable to parse OF data\n");
+		return dev_err_probe(&pdev->dev, ret, "Unable to parse OF data\n");
 
 	pm_runtime_enable(rga->dev);
 
-- 
2.35.1




More information about the linux-arm-kernel mailing list