[PATCH 4/7] arm64: dts: imx93: add blk ctrl node

[Krzysztof Kozlowski]

On 12/08/2022 10:46, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan at nxp.com>
> 
> Add i.MX93 BLK CTRL MIX node
> 
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index dd76472ced46..55f396723adb 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -112,6 +112,11 @@ aips1: bus at 44000000 {
>  			#size-cells = <1>;
>  			ranges;
>  
> +			anomix_ns_gpr: blk-ctrl-ns-anomix at 44210000 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +				compatible = "syscon";

No, syscon alone is not allowed.

> +				reg = <0x44210000 0x1000>;
> +			};
> +
>  			mu1: mailbox at 44230000 {
>  				compatible = "fsl,imx93-mu", "fsl,imx8ulp-mu";
>  				reg = <0x44230000 0x10000>;
> @@ -174,6 +179,11 @@ aips2: bus at 42000000 {
>  			#size-cells = <1>;
>  			ranges;
>  
> +			wakeupmix_gpr: blk-ctrl-wakeupmix at 42420000 {
> +				compatible = "syscon";

Ditto


Best regards,
Krzysztof