[EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

[Shenwei Wang]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: Thursday, August 11, 2022 10:11 AM
> To: Shenwei Wang <shenwei.wang at nxp.com>; robh+dt at kernel.org;
> krzysztof.kozlowski+dt at linaro.org; linus.walleij at linaro.org; brgl at bgdev.pl;
> shawnguo at kernel.org; s.hauer at pengutronix.de; kernel at pengutronix.de;
> festevam at gmail.com; dl-linux-imx <linux-imx at nxp.com>
> Cc: devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
> gpio at vger.kernel.org; linux-arm-kernel at lists.infradead.org; imx at lists.linux.dev
> Subject: Re: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver
> bindings
> 
> Caution: EXT Email
> 
> On 11/08/2022 17:52, Shenwei Wang wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> >> Sent: Thursday, August 11, 2022 9:36 AM
> >> To: Shenwei Wang <shenwei.wang at nxp.com>; robh+dt at kernel.org;
> >> krzysztof.kozlowski+dt at linaro.org; linus.walleij at linaro.org;
> >> brgl at bgdev.pl; shawnguo at kernel.org; s.hauer at pengutronix.de;
> >> kernel at pengutronix.de; festevam at gmail.com; dl-linux-imx
> >> <linux-imx at nxp.com>
> >> Cc: devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
> >> gpio at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> >> imx at lists.linux.dev
> >> Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio
> >> driver bindings
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml
> >>> b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml
> >>> new file mode 100644
> >>> index 000000000000..a1b024cddc97
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml
> >>> +description: |
> >>> +  This module provides the standard interface to control the
> >>> +  resource pins in SCU domain on i.MX8 platforms.
> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    enum:
> >>> +      - fsl,imx8qxp-sc-gpio
> >>
> >> Now the filename does not match compatible. Use the same compatible
> >> as filename.
> >
> > The subnodes under fsl,scu.yaml have their own naming rule. For
> > example, the watchdog compatible is "fsl,imx-sc-wdt", but the file name is
> "fsl,scu-wdt.yaml".
> 
> The other files have for example fsl,imx-sc-wdt, so they match compatible.

I don't see the file fsl,imx-sc-wdt you mentioned under the watchdog directory.

$ ls fsl*
fsl-imx7ulp-wdt.yaml  fsl-imx-wdt.yaml  fsl,scu-wdt.yaml

Regards,
Shenwei

> 
> > Is the filename required
> > to match its compatible?
> 
> Yes, that's the convention. Otherwise people tend to name the files in whatever
> way they like...
> 
> Best regards,
> Krzysztof