[PATCH] hwmon: Make use of devm_clk_get_enabled()

Guenter Roeck linux at roeck-us.net
Mon Aug 8 08:45:48 PDT 2022


On 8/8/22 07:30, Jonathan Cameron wrote:
> On Mon, 8 Aug 2022 09:54:08 +0200
> Uwe Kleine-König <u.kleine-koenig at pengutronix.de> wrote:
> 
>> On Mon, Aug 08, 2022 at 08:06:40AM +0200, Uwe Kleine-König wrote:
>>> Several drivers manually register a devm handler to disable their clk.
>>> Convert them to devm_clk_get_enabled().
>>>
>>> Acked-by: Guenter Roeck <linux at roeck-us.net>
>>> Reviewed-by: Nuno Sá <nuno.sa at analog.com>
>>> Acked-by: Jonathan Cameron <Jonathan.Cameron at huawei.com>
>>
>> Oh, the tags by Nuno Sá and Jonathan Cameron are a fake. I picked them
>> by mistake from the (similar) patch for iio. Please take care about that
>> before application. (i.e. drop them, or make me resend the patch without
>> the tags, or make the two give the tags post-factum :-)
>>
>> Best regards and sorry for the chaos,
>> Uwe
>>
> 
> Much like the IIO one you may get a request to split it by driver.
> I personally prefer per driver patches as Andy suggested, but meh, it is
> up to the hmwon maintainer.
> 

I don't like those one-patch-for-dozens-of-drivers approach very much
that seems to proliferate recently, and very much prefer per-driver patches.
Which is one reason for letting this hang ...

Guenter

> I'm feeling particularly unhelpful today. As it's not IIO patches going
> through another tree (like the IIO one was when I gave that tag):
> + simple patch to quickly review.
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron at huawei.com>
> 
> *evil laugh*
> 




More information about the linux-arm-kernel mailing list