[EXT] Re: [PATCH v1 2/3] dt-bindings: firmware: imx: Add imx-scu gpio node

[Shenwei Wang]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: Friday, August 5, 2022 1:56 AM
> To: Shenwei Wang <shenwei.wang at nxp.com>; robh+dt at kernel.org;
> krzysztof.kozlowski+dt at linaro.org; linus.walleij at linaro.org; brgl at bgdev.pl;
> shawnguo at kernel.org; s.hauer at pengutronix.de; kernel at pengutronix.de;
> festevam at gmail.com; dl-linux-imx <linux-imx at nxp.com>
> Cc: devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
> gpio at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: [EXT] Re: [PATCH v1 2/3] dt-bindings: firmware: imx: Add imx-scu gpio
> node
> 
> Caution: EXT Email
> 
> On 04/08/2022 20:49, Shenwei Wang wrote:
> > Add the description for imx-scu gpio subnode.
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang at nxp.com>
> > ---
> >  Documentation/devicetree/bindings/firmware/fsl,scu.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > index b40b0ef56978..080955b6edd8 100644
> > --- a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > @@ -30,6 +30,11 @@ properties:
> >        Clock controller node that provides the clocks controlled by the SCU
> >      $ref: /schemas/clock/fsl,scu-clk.yaml
> >
> > +  gpio:
> > +    description:
> > +      GPIO control over the SCU firmware APIs
> 
> I don't understand this description. How GPIO can control some API?

How about change to "Control the GPIO PINs on SCU domain over the firmware APIs"?

Thanks,
Shenwei

> 
> Best regards,
> Krzysztof