[PATCH 5/8] arm64: stacktrace: rework stack boundary discovery

Mark Rutland mark.rutland at arm.com
Tue Aug 2 05:29:38 PDT 2022


On Mon, Aug 01, 2022 at 10:22:45PM -0700, Kalesh Singh wrote:
> On Mon, Aug 1, 2022 at 5:12 AM Mark Rutland <mark.rutland at arm.com> wrote:
> >  static bool on_accessible_stack(const struct task_struct *tsk,
> >                                 unsigned long sp, unsigned long size,
> >                                 struct stack_info *info)
> >  {
> > -       if (info)
> > -               info->type = STACK_TYPE_UNKNOWN;
> > -
> > -       return (on_overflow_stack(sp, size, info) ||
> > -               on_hyp_stack(sp, size, info));
> > +       struct stack_info tmp;
> > +
> > +       tmp = stackinfo_get_overflow();
> > +       if (stackinfo_on_stack(&tmp, sp, size))
> > +               goto found;
> > +
> > +       tmp = stackinfo_get_hyp();
> > +       if (stackinfo_on_stack(&tmp, sp, size))
> > +               goto found;
> > +
> 
> nit: Some trailing whitespaces in this function, checkpatch should catch it

Whoops; I'll go throug the series and double-check for any more. Thanks for the
heads up!

> Reviewed-by: Kalesh Singh <kaleshsingh at google.com>

Thanks!

Mark.



More information about the linux-arm-kernel mailing list