[PATCH 2/2] regulator: sun20i: Add support for Allwinner D1 LDOs

Mark Brown broonie at kernel.org
Mon Aug 1 09:03:33 PDT 2022


On Sun, Jul 31, 2022 at 11:47:58PM -0500, Samuel Holland wrote:

> +static const struct regulator_desc sun20i_d1_analog_ldo_descs[] = {
> +	{
> +		.name		= "aldo",
> +		.supply_name	= "vdd33",
> +		.of_match	= "aldo",
> +		.ops		= &sun20i_d1_analog_ldo_ops,
> +		.type		= REGULATOR_VOLTAGE,
> +		.owner		= THIS_MODULE,
> +		.n_voltages	= BIT(3),

I'm really unconvinced that using BIT() is clearer than just writing the
number of voltages directly as a number.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20220801/e80d53df/attachment.sig>


More information about the linux-arm-kernel mailing list