[PATCH 3/3] ARM: dts: stm32: add STM32MP1-based Phytec board

Steffen Trumtrar s.trumtrar at pengutronix.de
Thu Apr 28 22:45:02 PDT 2022


Alexandre TORGUE <alexandre.torgue at foss.st.com> writes:

> [1. text/plain]
> On 4/14/22 12:07, Steffen Trumtrar wrote:
>> The Phytec STM32MP1 based SoMs feature up to 1 GB DDR3LP RAM, up to 1 GB eMMC,
>> up to 16 MB QSPI and up to 128 GB NAND flash.
>> Signed-off-by: Steffen Trumtrar <s.trumtrar at pengutronix.de>
>> ---
>>   arch/arm/boot/dts/Makefile                    |   3 +-
>>   .../dts/stm32mp157-phyboard-stm32mp1.dtsi     | 283 +++++++++++++
>>   .../dts/stm32mp157c-phycore-stm32mp1-3.dts    |  57 +++
>>   ...stm32mp157c-phycore-stm32mp15-pinctrl.dtsi | 318 +++++++++++++++
>>   .../stm32mp157c-phycore-stm32mp15-som.dtsi    | 373 ++++++++++++++++++
>>   5 files changed, 1033 insertions(+), 1 deletion(-)
>>   create mode 100644 arch/arm/boot/dts/stm32mp157-phyboard-stm32mp1.dtsi
>>   create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dts
>>   create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi
>>   create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi
>
> Can you split a bit those patches please ?
>

I can split it into the SOM and the board part.

(...)

>> diff --git a/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi
>
>
> Why create a new file pinctrl file for your board ? All groups are differents
> than existing ones ?
>

Exactly. Those groups overwrite the existing ones.
I could put them directly into
arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi, if you think
it aids readability.


Best regards,
Steffen

--
Pengutronix e.K.                | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |



More information about the linux-arm-kernel mailing list