[PATCH 04/10] arm64: dts: juno: use proper 'dma-channels/requests' properties
Robin Murphy
robin.murphy at arm.com
Thu Apr 28 03:43:01 PDT 2022
On 2022-04-27 16:58, Krzysztof Kozlowski wrote:
> pl330 DMA controller bindings documented 'dma-channels' and
> 'dma-requests' properties (without leading hash sign), so fix the DTS to
> match the bindings.
>
> Reported-by: Rob Herring <robh at kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> ---
> arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> index 4f40a5c8f565..96ef0ddc0b2d 100644
> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> @@ -829,8 +829,8 @@ dma-controller at 7ff00000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x0 0x7ff00000 0 0x1000>;
> #dma-cells = <1>;
> - #dma-channels = <8>;
> - #dma-requests = <32>;
> + dma-channels = <8>;
> + dma-requests = <32>;
BTW, this has always been wrong - Juno is configured with only 8 request
interfaces. But then it's moot anyway since PL330 has an ID register for
this stuff[1], so the DT properties aren't used by Linux, and shouldn't
be needed in general.
Thanks,
Robin.
[1]
https://developer.arm.com/documentation/ddi0424/d/programmers-model/register-descriptions/configuration-register-0?lang=en
> interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
More information about the linux-arm-kernel
mailing list