[PATCH v2] mm: make minimum slab alignment a runtime property

[Peter Collingbourne]

On Fri, Apr 22, 2022 at 11:03 AM Catalin Marinas
<catalin.marinas at arm.com> wrote:
>
> On Thu, Apr 21, 2022 at 02:15:48PM -0700, Peter Collingbourne wrote:
> > diff --git a/include/linux/slab.h b/include/linux/slab.h
> > index 373b3ef99f4e..80e517593372 100644
> > --- a/include/linux/slab.h
> > +++ b/include/linux/slab.h
> > @@ -201,21 +201,33 @@ void kmem_dump_obj(void *object);
> >  #endif
> >
> >  /*
> > - * Setting ARCH_SLAB_MINALIGN in arch headers allows a different alignment.
> > + * Setting ARCH_SLAB_MIN_MINALIGN in arch headers allows a different alignment.
> >   * Intended for arches that get misalignment faults even for 64 bit integer
> >   * aligned buffers.
> >   */
> > -#ifndef ARCH_SLAB_MINALIGN
> > -#define ARCH_SLAB_MINALIGN __alignof__(unsigned long long)
> > +#ifndef ARCH_SLAB_MIN_MINALIGN
> > +#define ARCH_SLAB_MIN_MINALIGN __alignof__(unsigned long long)
> > +#endif
>
> Sorry, only a drive-by comment, I'll look at the arm64 parts next week.
> I've seen it mentioned in the first version, what's the point of MIN_MIN
> and not just MIN?

I tried to explain it here:
https://lore.kernel.org/all/CAMn1gO5xHZvFSSsW5sTVaUBN_gS-cYYNMG3PnpgCmh7kk_Zx7Q@mail.gmail.com/

In the end I decided to go back to MIN so this is moot.

Peter