[PATCH v3 6/9] x86: resctrl: pseudo_lock: Fix to restore to original value when re-enabling hardware prefetch register

tarumizu.kohei at fujitsu.com tarumizu.kohei at fujitsu.com
Fri Apr 22 05:01:30 PDT 2022


Thanks for the comment.

> It would be nice to mention that the wrmsr()'s in this patch are only done inside of
> an interrupt-disabled region.  Without that little tidbit of information, it's not
> obviously correct that the smp_call_function() in patch 8/9 is correct.

I would like to add description that the wrmsr()'s in this patch are
only done inside of an interrupt-disabled region.
 
> The x86 code here looks reasonable otherwise.  It's a little bit of a shame that
> this is *ONLY* for BROADWELL_X for now, but I assume you were just
> conservative about it because that's all you have to test on.

That's right. It is possible to implement for other models based on
information provided by the Intel SDM. However, I didn't implement it
because I can test immediately with BROADWELL_X only.


More information about the linux-arm-kernel mailing list