[Linux-stm32] [PATCH v1 2/2] ARM: dts: stm32: add support for Protonic PRTT1x boards

Oleksij Rempel o.rempel at pengutronix.de
Fri Apr 22 00:10:25 PDT 2022


On Thu, Apr 21, 2022 at 03:11:41PM +0200, Yann Gautier wrote:
> > +&sdmmc2 {
> > +	pinctrl-names = "default", "opendrain", "sleep";
> > +	pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>;
> > +	pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_a>;
> > +	pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_a>;
> 
> Hi Oleksij,
> 
> > +	disable-wp;
> This is not used for eMMC (or SDIO), it can be removed.
> 
> > +	disable-cd;
> This property does not exist.
> 
> > +	none-removable;
> The right name is non-removable.
 
OK, thank you for review. I'll send v2

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the linux-arm-kernel mailing list