[PATCH] net/wireless: add debugfs exit function

Kalle Valo kvalo at kernel.org
Thu Apr 21 22:57:25 PDT 2022


Bernard Zhao <zhaojunkui2008 at 126.com> writes:

> This patch add exit debugfs function to mt7601u.
> Debugfs need to be cleanup when module is unloaded or load fail.

"load fail"? Please be more specific, are you saying that the second
module load fails or what?

>  drivers/net/wireless/mediatek/mt7601u/debugfs.c | 9 +++++++--
>  drivers/net/wireless/mediatek/mt7601u/init.c    | 1 +
>  drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 1 +

The title should be:

mt7601u: add debugfs exit function

> --- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
> @@ -9,6 +9,8 @@
>  #include "mt7601u.h"
>  #include "eeprom.h"
>  
> +static struct dentry *dir;

How will this work when there are multiple mt7601u devices? Because of
that, avoid using non-const static variables.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the linux-arm-kernel mailing list