[PATCH] clk: imx: scu: Fix pm_runtime_get_sync() error checking
Miaoqian Lin
linmq006 at gmail.com
Thu Apr 21 18:32:08 PDT 2022
On 2022/4/22 9:20, Stephen Boyd wrote:
> Quoting Miaoqian Lin (2022-04-11 23:57:18)
>> If the device is already in a runtime PM enabled state
>> pm_runtime_get_sync() will return 1, so a test for negative
>> value should be used to check for errors.
> Maybe it should use pm_runtime_resume_and_get() instead?
Fair enough,I will send patch v2.
>> Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support")
>> Signed-off-by: Miaoqian Lin <linmq006 at gmail.com>
>> ---
>> drivers/clk/imx/clk-scu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
>> index 083da31dc3ea..18c6190eeffd 100644
>> --- a/drivers/clk/imx/clk-scu.c
>> +++ b/drivers/clk/imx/clk-scu.c
>> @@ -529,7 +529,7 @@ static int imx_clk_scu_probe(struct platform_device *pdev)
>> pm_runtime_enable(dev);
>>
>> ret = pm_runtime_get_sync(dev);
>> - if (ret) {
>> + if (ret < 0) {
>> pm_genpd_remove_device(dev);
>> pm_runtime_disable(dev);
>> return ret;
>> --
>> 2.17.1
>>
More information about the linux-arm-kernel
mailing list