[PATCH] ARM: highbank: Fix missing of_node_put in highbank_init()
Andre Przywara
andre.przywara at arm.com
Wed Apr 20 07:26:17 PDT 2022
On Fri, 8 Apr 2022 09:48:17 +0000
cgel.zte at gmail.com wrote:
Hi,
> From: Lv Ruyi <lv.ruyi at zte.com.cn>
>
> of_find_compatible_node() returns node pointer with refcount incremented,
> use of_node_put() on it to decrease refcount when done.
Thanks for the patch, looks alright to me.
There is actually another occurrence in the same file, will send a patch
ASAP.
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi at zte.com.cn>
Fixes: 220e6cf7b793d702596506a8c4bf1f4fd4040df1 ("ARM: add Highbank core
platform support")
Reviewed-by: Andre Przywara <andre.przywara at arm.com>
Arnd, Olof, can you please take this through the soc tree as a fix,
whenever you find time?
Thanks!
Andre
> ---
> arch/arm/mach-highbank/highbank.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-highbank/highbank.c b/arch/arm/mach-highbank/highbank.c
> index db607955a7e4..fe82c3d16ffd 100644
> --- a/arch/arm/mach-highbank/highbank.c
> +++ b/arch/arm/mach-highbank/highbank.c
> @@ -141,6 +141,7 @@ static void __init highbank_init(void)
> /* Map system registers */
> np = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs");
> sregs_base = of_iomap(np, 0);
> + of_node_put(np);
> WARN_ON(!sregs_base);
>
> pm_power_off = highbank_power_off;
More information about the linux-arm-kernel
mailing list