[PATCH v2] staging: vchiq_arm: change vchiq_platform_init from global to static
Greg KH
gregkh at linuxfoundation.org
Tue Apr 19 07:19:55 PDT 2022
On Tue, Apr 19, 2022 at 09:36:16AM -0400, Tom Rix wrote:
> Smatch reports this issue
> vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' was not declared. Should it be static?
>
> vchiq_platform_init is only used in vchiq_arm.c. Single file variables should
> not be global so change vchiq_platform_init's storage-class specifier to static.
You did not change a variable, you changed a function type.
>
> Signed-off-by: Tom Rix <trix at redhat.com>
> ---
> v2: refomat commit log
Why did you not fix the build breakage?
{sigh}
More information about the linux-arm-kernel
mailing list