[PATCH v4 2/5] fpga: fix for coding style issues

Nava kishore Manne navam at xilinx.com
Mon Apr 18 02:54:35 PDT 2022


Hi Joe,

	Please find my response inline.

> -----Original Message-----
> From: Joe Perches <joe at perches.com>
> Sent: Saturday, April 16, 2022 10:29 PM
> To: Nava kishore Manne <navam at xilinx.com>; mdf at kernel.org;
> hao.wu at intel.com; yilun.xu at intel.com; trix at redhat.com; Michal Simek
> <michals at xilinx.com>; linux-fpga at vger.kernel.org; linux-
> kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; git
> <git at xilinx.com>
> Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues
> 
> On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote:
> > fixes the below checks reported by checkpatch.pl Lines should not end
> > with a '('
> > Alignment should match open parenthesis
> 
> in fpga-mgr:
> 	Another possibillty would be to change the function arguments
> 
> and
> 
> in fpga-region:
> 	Ideally keep the include declaration and definition styles synced
> 

These changes are targeted to fix the checks reported by checkpatch.pl without touching the actual functionality.

Regards,
Navakishore.



More information about the linux-arm-kernel mailing list