[PATCH 2/6] arm64: stacktrace: delete PCS comment

Mark Rutland mark.rutland at arm.com
Wed Apr 13 09:11:47 PDT 2022


On Wed, Apr 13, 2022 at 04:59:14PM +0100, Mark Brown wrote:
> On Wed, Apr 13, 2022 at 03:59:06PM +0100, Mark Rutland wrote:
> > The comment at the top of stacktrace.c isn't all that helpful, as it's
> > not associated with the code which inspects the frame record, and the
> > code example isn't representative of common code generation today.
> 
> Reviewed-by: Mark Brown <broonie at kernel.org>
> 
> though I do wonder if it might be better to rather than remove it expand
> it to be a bit of an essay on what actually happens these days, that
> could be better placed in Documentation/ though.

FWIW, I want to add a Documentation/arm64/unwinding.{whatever} to give links to
the relevant documentation (e.g. the AAPCS64 docs) and to explain the
arm64-specific unwinding concerns, but I haven't had the chance to write that
yet.

Either way I'd like to remove this comment since it's both misplaced and
misleading, so thanks for the Reviewed-by tag!

Mark.



More information about the linux-arm-kernel mailing list